Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea: secondary auto detect #141

Open
lirannl opened this issue Nov 5, 2014 · 7 comments
Open

Idea: secondary auto detect #141

lirannl opened this issue Nov 5, 2014 · 7 comments

Comments

@lirannl
Copy link

lirannl commented Nov 5, 2014

I'm pretty certain you could detect the colour of a pixel in the top of the foreground app, and use that as the auto detected colour, when your other methods (or if no manual colours are set) don't work. Of course, make that optional

@PwnicornDev
Copy link

👍
There's a new Xposed module called “Flat Style Colored Bars” which seems to do exactly this. Unfortunately, it's closed source and the developer plans to make it a paid app when it's finished.

@lirannl
Copy link
Author

lirannl commented Nov 7, 2014

I have 4.1.2. And it doesn't seem like anyone's going to make an updated kernel for Haier w910.

@GermainZ
Copy link
Collaborator

GermainZ commented Nov 8, 2014

Does this offer any advantages over manually setting the color (you could use the notification color picker so you don't have to take a screenshot yourself)? It looks like something that could noticeably impact performance for little to no convenience.

@lirannl
Copy link
Author

lirannl commented Nov 13, 2014

No, not constantly. Only once per activity!

@GermainZ
Copy link
Collaborator

That doesn't answer my question. In fact, it only reinforces my point.

@PwnicornDev
Copy link

The advantage is that this would work automatically, just like the current implementation, but in many cases more accurate.

@GermainZ
Copy link
Collaborator

The advantage is that this would work automatically, just like the current implementation

From my previous comment:

It looks like something that could noticeably impact performance for little to no convenience.

This could basically be the very last resort if we can't get material design apps (#129) to work correctly otherwise, but we'd like to avoid such an approach if possible.


but in many cases more accurate.

From my previous commentL

you could use the notification color picker so you don't have to take a screenshot yourself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants