Skip to content

unit tests with github actions and torch 2.5 fail #267

Open
@flxst

Description

@flxst

System Info

unit tests with github actions and torch==2.5.1

🐛 Describe the bug

[This issue is a follow-up to PR #266]

Unit testing with github actions fails with torch 2.5: https://github.com/Modalities/modalities/actions/runs/11709209563/job/32827392743

The exact reason is unclear, it seems to be related to the flash-attn dependency though: The built flash-attn wheel using torch 2.5 has size=144263 (see line 471 in "install dependencies" here), while its counterpart using torch 2.4 has size=187328293 (see line 600 in "install dependencies" here).

Note that unit testing works locally (on a DGX box) for both torch 2.4 and 2.5, so it seems that the issue is related to the github actions runner.

Additional remark: Once the problem is fixed, the torch version should be unpinned, i.e. the changes in da5862e should be reversed.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions