Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lora: Support merged linear layers #244

Open
rrutmann opened this issue Sep 2, 2024 · 0 comments
Open

Lora: Support merged linear layers #244

rrutmann opened this issue Sep 2, 2024 · 0 comments

Comments

@rrutmann
Copy link
Collaborator

rrutmann commented Sep 2, 2024

Feature request

Currently, all linear layers that are specified in our training config to be adapted for Lora are converted to type LoraLinearLayer. There might be cases, where different matrices are combined into one linear layer for efficiency (e.g. q, k, v in the attention layer are combined in a single layer q_k_v). Such layers have to be treated differently and should therefore be converted to LoraMergedLinearLayer instead.

Motivation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant