-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
edit button and bookmark, print #18
Comments
This was needed for bootstrap5:
so li tags shouldn't be in those shortcodes |
@Jimmi08 Could you test again with the latest version and see if the EDIT and PRINT shortcodes are fully customizable now? I still need to do some work on the bookmarks button, but not sure yet how to approach it (because it changes depending on whether a recipe is bookmarked or not). |
@Jimmi08 I have made some changes that should allow to template the bookmark functionality properly now. I'm still not really happy with the functionality but happy to hear your findings. For me, there's some weird refresh/moving behaviour going on, when clicking the add/remove link. |
Motivation
Proposed Solution
Could you add parameter or move
<li></li>
to template? When you want to use edit button separately withou<ul></ul>
correct icon
Could you use core solution for glyphs? Your fa-pencil is not displayed in bootstrap 5 theme
Quick fix: fa-edit is working
The text was updated successfully, but these errors were encountered: