Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull requests should have CI run against them #16

Open
brentleyjones opened this issue Apr 3, 2023 · 1 comment
Open

Pull requests should have CI run against them #16

brentleyjones opened this issue Apr 3, 2023 · 1 comment

Comments

@brentleyjones
Copy link
Contributor

Before #15 is done, and preferably for the first PR of the rewrite, we should have CI checks running on pull requests. We can probably use BuildBuddy Workflows and GitHub actions similar to rules_xcodeproj.

Some things that we should check (and not all of it needs to be there at the start):

  • Unit tests
  • Linting
  • Commit message check
  • Documentation check
@pepicrft
Copy link

@brentleyjones I'd be happy to take this one on, but I'd need some guidance on the Bazel side of things. Could you give me some pointers around what's the interface through Bazel?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants