Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GridObjectCollection from MRTK2 for non-canvas UI layout #827

Open
Schroedingers-Cat opened this issue Jul 5, 2024 · 2 comments
Open
Labels
Priority: Low The priority of the issue is low. Type: Feature Request A request for a new feature that can be included with the next minor version release.

Comments

@Schroedingers-Cat
Copy link

Problem

MRTK2 has a GridObjectCollection which is missing in MRTK3. Here's a link to the original docs.

Solution

Port missing functionality from MRTK2 to MRTK3

Considered Alternatives

Port it myself. I have no idea what's up ahead. Any specifics you'd want to see in a possible PR?

Additional context

I'm porting my project from MRTK2 to MRTK3 and it makes use of the GridObjectCollection several times.

@Schroedingers-Cat Schroedingers-Cat added Needs: Triage Needs to be triaged. Type: Feature Request A request for a new feature that can be included with the next minor version release. labels Jul 5, 2024
@anonymous2585
Copy link
Contributor

If you are using canvas, you can use Unity's components "Vertical Layout Group", "Vertical Layout Group" or "Grid Layout Group".
The button prefab for canvas is in Packages/org.mixedrealitytoolkit.uxcomponents/Button/Prefabs/Action Button.prefab

If you don't use canvas, why not using them?

@shaynie shaynie removed the Needs: Triage Needs to be triaged. label Jul 24, 2024
@shaynie shaynie changed the title Add GridObjectCollection from MRTK2 Add GridObjectCollection from MRTK2 for non-canvas UI layout Jul 24, 2024
@shaynie shaynie added the Priority: Low The priority of the issue is low. label Jul 24, 2024
@Schroedingers-Cat
Copy link
Author

Thanks for the heads up! I hadn't thought of the availability of the layout group components when using the canvas based UX components. This turned out to be a perfectly fine replacement for our use case of the GridObjectCollection script.

For the MRTK2 to MRTK3 migration docs, I'd suggest to just mention the GridObjectCollection component somewhere so that people looking for a replacement can quickly find that info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low The priority of the issue is low. Type: Feature Request A request for a new feature that can be included with the next minor version release.
Projects
None yet
Development

No branches or pull requests

3 participants