Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ModuleInFrame unit test to use new location implementation #213

Open
2 tasks
fallscameron01 opened this issue Dec 2, 2020 · 0 comments
Open
2 tasks

Update ModuleInFrame unit test to use new location implementation #213

fallscameron01 opened this issue Dec 2, 2020 · 0 comments
Assignees
@mat-px
Labels
enhancement New feature or request good first issue Good for newcomers Module Module related task. vision

Comments

@fallscameron01
Copy link
Member

fallscameron01 commented Dec 2, 2020 •
edited
Loading

Description of Problem

The unit test for ModuleInFrame needs to be updated to use the new implementation isInFrame() from the ModuleLocation class.

Requirements

  • Should be left as seperate unit test from location so isInFrame and getCenter are tested seperately.
  • Update existing unit test to use new implementation of isInFrame().
@fallscameron01 fallscameron01 added enhancement New feature or request good first issue Good for newcomers Module Module related task. vision labels Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mat-px mat-px

Labels
enhancement New feature or request good first issue Good for newcomers Module Module related task. vision
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fallscameron01 @mat-px