Feature/better turn #239
Open
Feature/better turn #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewad3
suggested changes
Mar 17, 2021
pieperm
suggested changes
Mar 18, 2021
pieperm
suggested changes
Mar 18, 2021
flight/utils/movement_controller.py
Outdated
| @@ -95,25 +96,52 @@ async def move_to(self, drone: System, pylon: LatLon) -> bool: | |||
| return True | |||
| count += 1 | |||
|
|
|||
| async def turn(self, drone: System) -> bool: | |||
| async def turn(self, drone: System, degrees_turned = 180: int, left_turn = True: bool, time = 3.5: float) -> bool: | |||
There was a problem hiding this comment.
Another possible issue I noticed is that adding these arguments is not reflected when the function is called. That is, in states/early_laps.py, the call to mover.turn() is only passed a drone. Are we planning on using the default arguments for the pylon laps?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The turn function now allows for variable input and adjusts the time, degrees, and direction of the turn based off of function variables.