Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

故事板贴图比例不正确 #5

Open
xLin7648 opened this issue Nov 28, 2022 · 14 comments
Open

故事板贴图比例不正确 #5

xLin7648 opened this issue Nov 28, 2022 · 14 comments
Labels
invalid This doesn't seem right

Comments

@xLin7648
Copy link
Contributor

result.heightPercent = result.height / math.round(1080 * 0.6666); //result.height / 1080;
故事板贴图比较正确比例

@MisaLiu
Copy link
Owner

MisaLiu commented Nov 28, 2022

你要不直接开个 pr

@xLin7648
Copy link
Contributor Author

pr?

@xLin7648 xLin7648 reopened this Nov 28, 2022
@MisaLiu
Copy link
Owner

MisaLiu commented Nov 28, 2022

我意思是你先 Fork 一份自己改改然后开个 Pull Request

@xLin7648
Copy link
Contributor Author

@MisaLiu MisaLiu added the invalid This doesn't seem right label Nov 28, 2022
@MisaLiu
Copy link
Owner

MisaLiu commented Nov 29, 2022

在合并 #6 之后,我在播放 这张谱面 时发现贴图缩放出现了错误,因此决定撤回该 PR 的更改并重新开放此 issue,直到自定义贴图缩放问题彻底修复为止

@MisaLiu MisaLiu reopened this Nov 29, 2022
MisaLiu added a commit that referenced this issue Nov 29, 2022
@xLin7648
Copy link
Contributor Author

line.csv的缩放大概是lineScale / 60
rpe的话那个textureScale在仅在16:9下正常

@MisaLiu
Copy link
Owner

MisaLiu commented Dec 1, 2022

line.csv的缩放大概是lineScale / 60 rpe的话那个textureScale在仅在16:9下正常

没看懂到底要改啥

也许你是想改 https://github.com/MisaLiu/phi-chart-render/blob/master/src/chart/convert/rephiedit.js#L262

@xLin7648
Copy link
Contributor Author

xLin7648 commented Dec 1, 2022

pec和pez的故事板分开适配

@xLin7648
Copy link
Contributor Author

xLin7648 commented Dec 1, 2022

pec
judgeline.baseScaleX = judgeline.baseScaleY = this.renderSize.lineScale / 60;
pez
目前不知道怎么算(

@MisaLiu
Copy link
Owner

MisaLiu commented Dec 1, 2022

pec judgeline.baseScaleX = judgeline.baseScaleY = this.renderSize.lineScale / 60; pez 目前不知道怎么算(

你的意思是重新计算两个谱面的缩放适配是吗

@xLin7648
Copy link
Contributor Author

xLin7648 commented Dec 1, 2022

pec故事板和pez故事板缩放计算公式不一样

@MisaLiu
Copy link
Owner

MisaLiu commented Dec 1, 2022

pec故事板和pez故事板缩放计算公式不一样

所以我才问需不需要重新计算两个谱面类型的缩放适配啊

@xLin7648
Copy link
Contributor Author

xLin7648 commented Dec 1, 2022

@MisaLiu
Copy link
Owner

MisaLiu commented Dec 1, 2022

那你可以看看我上面提到的那个文件和 https://github.com/MisaLiu/phi-chart-render/blob/master/src/chart/index.js#L159 这个文件,我不是很清楚你到底要怎么改所以我就不参与了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants