Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Breadcrumb level #57

Merged
merged 5 commits into from
Oct 22, 2024
Merged

feat: Breadcrumb level #57

merged 5 commits into from
Oct 22, 2024

Conversation

miquelbeltran
Copy link
Contributor

@miquelbeltran miquelbeltran commented Oct 22, 2024 •
edited
Loading

feat: Breadcrumb level

Description 📝

  • Purpose: Adds Breadcrumb level property
  • Approach: Add property, test and examples

Type of change

  • New feature (non-breaking change which adds functionality)

Updates

  • Added BreadcrumbLevel enum.
  • Added field to BreadcrumbDetails class and constructor.
  • Add level to different breadcrumb creation methods, also for JS interop.
  • Fixed JS interop as the current implement was not correct

Screenshots 📷

Screenshot from 2024-10-22 09-49-16
Screenshot from 2024-10-22 09-49-07

Test plan 🧪

  • Included the breadcrumb level in unit tests.
  • Added breacrumb level to sample code. See screenshots for the different types of breadcrumbs with different levels.

Author to check 👓

  • Project and all contained modules builds successfully
  • Self-/dev-tested
  • Unit/UI/Automation/Integration tests provided where applicable
  • Code is written to standards
  • Appropriate documentation written (code comments, internal docs)

Reviewer to check ✔️

  • Project and all contained modules builds successfully
  • Change has been dev-/reviewer-tested, where possible
  • Unit/UI/Automation/Integration tests provided where applicable
  • Code is written to standards
  • Appropriate documentation written (code comments, internal docs)

ProRedCat
ProRedCat approved these changes Oct 22, 2024
View reviewed changes
Copy link

@ProRedCat ProRedCat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks for the quick work on implementing this

@miquelbeltran miquelbeltran merged commit 78063c5 into main Oct 22, 2024
8 checks passed
@miquelbeltran miquelbeltran deleted the breadcrumb-level branch October 22, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ProRedCat ProRedCat ProRedCat approved these changes

@TheRealAgentK TheRealAgentK Awaiting requested review from TheRealAgentK

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miquelbeltran @ProRedCat