forked from uazo/cromite
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathRemove-blocklisted-URLs-upon-bookmark-creation.patch
47 lines (42 loc) · 2.27 KB
/
Remove-blocklisted-URLs-upon-bookmark-creation.patch
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
From: csagan5 <[email protected]>
Date: Fri, 21 Aug 2020 22:39:23 +0200
Subject: Remove blocklisted URLs upon bookmark creation
License: GPL-3.0-only - https://spdx.org/licenses/GPL-3.0-only.html
---
.../chrome/browser/bookmarks/TabBookmarker.java | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/TabBookmarker.java b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/TabBookmarker.java
--- a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/TabBookmarker.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/TabBookmarker.java
@@ -19,6 +19,11 @@ import org.chromium.components.bookmarks.BookmarkItem;
import org.chromium.components.bookmarks.BookmarkType;
import org.chromium.components.browser_ui.bottomsheet.BottomSheetController;
+import org.chromium.chrome.browser.profiles.Profile;
+import org.chromium.chrome.browser.suggestions.SuggestionsDependencyFactory;
+import org.chromium.chrome.browser.suggestions.mostvisited.MostVisitedSites;
+import org.chromium.url.GURL;
+
/**
* Helper class for managing the UI flow for bookmarking the active tab and kicking off the backend.
* Shows a snackbar if a new bookmark was added. If the bookmark already exists, kicks off edit
@@ -30,6 +35,7 @@ public class TabBookmarker {
private final Supplier<BottomSheetController> mBottomSheetControllerSupplier;
private final Supplier<SnackbarManager> mSnackbarManagerSupplier;
private final boolean mIsCustomTab;
+ private MostVisitedSites mMostVisitedSites;
/**
* Constructor.
@@ -105,6 +111,13 @@ public class TabBookmarker {
return;
}
+ // remove blocklisted URL from most visited sites
+ if (mMostVisitedSites == null) {
+ mMostVisitedSites =
+ SuggestionsDependencyFactory.getInstance().createMostVisitedSites(Profile.getLastUsedRegularProfile());
+ }
+ mMostVisitedSites.removeBlocklistedUrl(tabToBookmark.getOriginalUrl());
+
// Defense in depth against the UI being erroneously enabled.
final BookmarkModel bookmarkModel = mBookmarkModelSupplier.get();
if (bookmarkModel == null || !bookmarkModel.isEditBookmarksEnabled()) {
--