Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#Setting the namespace via the package attribute in the source AndroidManifest.xml is no longer supported. in andorid #178

Open
tushar-kuchch opened this issue Jul 5, 2024 · 1 comment

Comments

@tushar-kuchch
Copy link

No description provided.

@MCvanderBerg
Copy link

Hi @tushar-kuchch. I've recently ran into this problem as well. I upgraded my project to android gradle version 8.1.1 and I'm now getting the error message. I hope that we are talking about the same issue as you didn't provide a description:

Incorrect package="com.ibits.react_native_in_app_review" found in source AndroidManifest.xml: /Users/christiaanvanderberg/ODO/rn-app/node_modules/react-native-in-app-review/android/src/main/AndroidManifest.xml.
Setting the namespace via the package attribute in the source AndroidManifest.xml is no longer supported.
Recommendation: remove package="com.ibits.react_native_in_app_review" from the source AndroidManifest.xml: /Users/christiaanvanderberg/ODO/rn-app/node_modules/react-native-in-app-review/android/src/main/AndroidManifest.xml.

As stated above the solution is to remove "package="com.ibits.react_native_in_app_review" from androidManifest and add it to the build.gradle file like:

android {
namespace "com.ibits.react_native_in_app_review"

...
}

I do hope that the repo makes the necessary changes. This isn't the only repository that has given me this error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants