Skip to content

Commit 7f8d377

Browse files
authored
Merge pull request #11220 from MinaProtocol/get-rid-of-some-submodules
Remove some submodules in favour of opam pins
2 parents 913343f + 4cd98d8 commit 7f8d377

File tree

7 files changed

+109
-16
lines changed

7 files changed

+109
-16
lines changed

.gitmodules

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,6 @@
44
[submodule "src/external/ppx_optcomp"]
55
path = src/external/ppx_optcomp
66
url = https://github.com/MinaProtocol/ppx_optcomp
7-
[submodule "src/external/async_kernel"]
8-
path = src/external/async_kernel
9-
url = https://github.com/MinaProtocol/async_kernel
10-
[submodule "src/external/rpc_parallel"]
11-
path = src/external/rpc_parallel
12-
url = https://github.com/MinaProtocol/rpc_parallel.git
137
[submodule "frontend/wallet/tablecloth"]
148
path = frontend/wallet/tablecloth
159
url = https://github.com/bkase/tablecloth
@@ -23,9 +17,6 @@
2317
[submodule "src/external/c-reference-signer"]
2418
path = src/external/c-reference-signer
2519
url = https://github.com/MinaProtocol/c-reference-signer.git
26-
[submodule "src/external/capnp-ocaml"]
27-
path = src/external/capnp-ocaml
28-
url = https://github.com/o1-labs/capnp-ocaml.git
2920
[submodule "src/lib/snarky_js_bindings/snarkyjs"]
3021
path = src/lib/snarky_js_bindings/snarkyjs
3122
url = https://github.com/o1-labs/snarkyjs.git

nix/ocaml.nix

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,8 @@ let
1515
repos = [ external-repo inputs.opam-repository ];
1616

1717
export = opam-nix.importOpam ../src/opam.export;
18-
external-packages =
19-
getAttrs [ "sodium" "capnp" "rpc_parallel" "async_kernel" "base58" ]
20-
(builtins.mapAttrs (_: last) (opam-nix.listRepo external-repo));
18+
external-packages = pkgs.lib.getAttrs [ "sodium" "base58" ]
19+
(builtins.mapAttrs (_: pkgs.lib.last) (opam-nix.listRepo external-repo));
2120

2221
difference = a: b:
2322
filterAttrs (name: _: !builtins.elem name (builtins.attrNames b)) a;

scripts/pin-external-packages.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
# update and pin packages, used by CI
44

5-
PACKAGES="ocaml-sodium capnp-ocaml rpc_parallel async_kernel coda_base58"
5+
PACKAGES="ocaml-sodium coda_base58"
66

77
git submodule sync && git submodule update --init --recursive
88

src/external/async_kernel

Lines changed: 0 additions & 1 deletion
This file was deleted.

src/external/capnp-ocaml

Lines changed: 0 additions & 1 deletion
This file was deleted.

src/external/rpc_parallel

Lines changed: 0 additions & 1 deletion
This file was deleted.

src/opam.export

Lines changed: 106 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -240,6 +240,9 @@ installed: [
240240
]
241241
pinned: [
242242
"graphql_ppx.1.2.2"
243+
"capnp.3.4.0"
244+
"rpc_parallel.v0.14.0"
245+
"async_kernel.v0.14.0"
243246
]
244247
package "graphql_ppx" {
245248
opam-version: "2.0"
@@ -271,3 +274,106 @@ package "graphql_ppx" {
271274
checksum: "sha256=8aff33988218c99a95a91fb04ef703a3b8cde0676b7a90ee72478959829867d8"
272275
}
273276
}
277+
package "capnp" {
278+
opam-version: "2.0"
279+
version: "3.4.0"
280+
maintainer: "Paul Pelzl <[email protected]>"
281+
authors: "Paul Pelzl <[email protected]>"
282+
homepage: "https://github.com/capnproto/capnp-ocaml"
283+
bug-reports: "https://github.com/capnproto/capnp-ocaml/issues"
284+
license: "BSD-2-Clause"
285+
depends: [
286+
"ocaml" {>= "4.03.0"}
287+
"dune" {>= "1.0"}
288+
"result"
289+
"base" {>= "v0.11"}
290+
"stdio"
291+
"base_quickcheck" {with-test}
292+
"ocplib-endian" {>= "0.7"}
293+
"res"
294+
"stdint" {>= "0.5.1"}
295+
"ounit" {with-test}
296+
"conf-capnproto" {with-test}
297+
]
298+
build: [
299+
["dune" "build" "-p" name "-j" jobs]
300+
["dune" "build" "-p" name "-j" jobs "@runtest" "@src/benchmark/benchmarks"] {with-test}
301+
]
302+
dev-repo: "git+https://github.com/capnproto/capnp-ocaml.git"
303+
synopsis:
304+
"OCaml code generation plugin for the Cap'n Proto serialization framework"
305+
description: """
306+
Cap'n Proto is a multi-language code generation framework designed for
307+
high performance through the use of lazy parsing and arena allocation.
308+
This package provides a plugin for the Cap'n Proto compiler which enables
309+
OCaml code generation, as well as corresponding runtime library support."""
310+
url {
311+
src: "https://github.com/o1-labs/capnp-ocaml/archive/6f4913503cc971ab34df9bf9d4c65778fe05eb8f.tar.gz"
312+
checksum: "sha256=03aac06742f3d4ec8a189f0db65d46393b7497e8637ece15c39ff4ec01117b8b"
313+
}
314+
}
315+
package "rpc_parallel" {
316+
opam-version: "2.0"
317+
version: "v0.14.0"
318+
maintainer: "[email protected]"
319+
authors: ["Jane Street Group, LLC <[email protected]>"]
320+
homepage: "https://github.com/janestreet/rpc_parallel"
321+
bug-reports: "https://github.com/janestreet/rpc_parallel/issues"
322+
dev-repo: "git+https://github.com/janestreet/rpc_parallel.git"
323+
doc: "https://ocaml.janestreet.com/ocaml-core/latest/doc/rpc_parallel/index.html"
324+
license: "MIT"
325+
build: [
326+
["dune" "build" "-p" name "-j" jobs]
327+
]
328+
depends: [
329+
"ocaml" {>= "4.08.0"}
330+
"async" {>= "v0.13" & < "v0.15"}
331+
"core" {>= "v0.13" & < "v0.15"}
332+
"core_kernel" {>= "v0.13" & < "v0.15"}
333+
"ppx_jane" {>= "v0.13" & < "v0.15"}
334+
"sexplib" {>= "v0.13" & < "v0.15"}
335+
"dune" {>= "2.0.0"}
336+
]
337+
synopsis: "Type-safe parallel library built on top of Async_rpc"
338+
description: "
339+
Rpc_parallel offers an API to define various workers and protocols,
340+
spawn workers as separate processes, and communicate with them using
341+
Async Rpc.
342+
343+
"
344+
url {
345+
src: "https://github.com/MinaProtocol/rpc_parallel/archive/39d6eec98705d5cc1f3ed8479ef19b1a1e0ee70e.tar.gz"
346+
checksum: "sha256=2b6c758433c5fd12b4971380147be96f0ce5d239932fc7f6df1d84f306bcbd2a"
347+
}
348+
}
349+
package "async_kernel" {
350+
opam-version: "2.0"
351+
version: "v0.14.0"
352+
maintainer: "[email protected]"
353+
authors: ["Jane Street Group, LLC <[email protected]>"]
354+
homepage: "https://github.com/janestreet/async_kernel"
355+
bug-reports: "https://github.com/janestreet/async_kernel/issues"
356+
dev-repo: "git+https://github.com/janestreet/async_kernel.git"
357+
doc: "https://ocaml.janestreet.com/ocaml-core/latest/doc/async_kernel/index.html"
358+
license: "MIT"
359+
build: [
360+
["dune" "build" "-p" name "-j" jobs]
361+
]
362+
depends: [
363+
"ocaml" {>= "4.08.0"}
364+
"core_kernel" {>= "v0.13" & < "v0.15"}
365+
"ppx_jane" {>= "v0.13" & < "v0.15"}
366+
"dune" {>= "2.0.0"}
367+
]
368+
synopsis: "Monadic concurrency library"
369+
description: "
370+
Part of Jane Street's Core library
371+
The Core suite of libraries is an industrial strength alternative to
372+
OCaml's standard library that was developed by Jane Street, the
373+
largest industrial user of OCaml.
374+
"
375+
url {
376+
src: "https://github.com/MinaProtocol/async_kernel/archive/bf02e69c129b6ffec97cc5b7a5d85125802968bb.tar.gz"
377+
checksum: "sha256=ae824169495106fa9099aa53c0367e58651de426f70653897b3e1168c9a7edb6"
378+
}
379+
}

0 commit comments

Comments
 (0)