From 1cd49873a8d5862e24de1dfe8ed3c0921b0dda07 Mon Sep 17 00:00:00 2001
From: Mike Popoloski <mike@popoloski.com>
Date: Mon, 10 Feb 2025 19:55:59 -0500
Subject: [PATCH] Fix build warnings, add docs for new warning

---
 include/slang/analysis/AnalysisManager.h   |  6 +++---
 include/slang/analysis/AnalyzedProcedure.h |  2 +-
 include/slang/analysis/DataFlowAnalysis.h  |  4 ++--
 scripts/warning_docs.txt                   | 13 +++++++++++++
 source/analysis/AnalysisManager.cpp        |  2 +-
 source/analysis/AnalyzedProcedure.cpp      |  2 +-
 6 files changed, 21 insertions(+), 8 deletions(-)

diff --git a/include/slang/analysis/AnalysisManager.h b/include/slang/analysis/AnalysisManager.h
index ffae2c7fc..9915e5efc 100644
--- a/include/slang/analysis/AnalysisManager.h
+++ b/include/slang/analysis/AnalysisManager.h
@@ -35,18 +35,18 @@ class AnalyzedScope;
 class SLANG_EXPORT AnalyzedInstance {
 public:
     /// The symbol that was analyzed.
-    const ast::InstanceSymbol& symbol;
+    not_null<const ast::InstanceSymbol*> symbol;
 
     /// Constructs a new AnalyzedInstance object.
     AnalyzedInstance(AnalysisManager& analysisManager, const ast::InstanceSymbol& symbol) :
-        symbol(symbol), analysisManager(analysisManager) {}
+        symbol(&symbol), analysisManager(&analysisManager) {}
 
     /// Returns the analyzed body of the instance, if available.
     /// If the body has not been analyzed yet, this will return nullptr.
     const AnalyzedScope* getBody() const;
 
 private:
-    AnalysisManager& analysisManager;
+    not_null<AnalysisManager*> analysisManager;
 };
 
 /// Represents an analyzed AST scope.
diff --git a/include/slang/analysis/AnalyzedProcedure.h b/include/slang/analysis/AnalyzedProcedure.h
index c550b7266..fd7ef72eb 100644
--- a/include/slang/analysis/AnalyzedProcedure.h
+++ b/include/slang/analysis/AnalyzedProcedure.h
@@ -23,7 +23,7 @@ class AnalysisManager;
 
 class SLANG_EXPORT AnalyzedProcedure {
 public:
-    const ast::ProceduralBlockSymbol& procedureSymbol;
+    not_null<const ast::ProceduralBlockSymbol*> procedureSymbol;
 
     AnalyzedProcedure(AnalysisManager& analysisManager, AnalysisContext& context,
                       const ast::ProceduralBlockSymbol& symbol);
diff --git a/include/slang/analysis/DataFlowAnalysis.h b/include/slang/analysis/DataFlowAnalysis.h
index 7d3627583..48a302b10 100644
--- a/include/slang/analysis/DataFlowAnalysis.h
+++ b/include/slang/analysis/DataFlowAnalysis.h
@@ -106,7 +106,7 @@ class SLANG_EXPORT DataFlowAnalysis : public AbstractFlowAnalysis<DataFlowAnalys
 
             owner.visit(expr.value());
 
-            auto guard = owner.saveLValueFlag();
+            [[maybe_unused]] auto guard = owner.saveLValueFlag();
             owner.visit(expr.selector());
         }
 
@@ -121,7 +121,7 @@ class SLANG_EXPORT DataFlowAnalysis : public AbstractFlowAnalysis<DataFlowAnalys
 
             owner.visit(expr.value());
 
-            auto guard = owner.saveLValueFlag();
+            [[maybe_unused]] auto guard = owner.saveLValueFlag();
             owner.visit(expr.left());
             owner.visit(expr.right());
         }
diff --git a/scripts/warning_docs.txt b/scripts/warning_docs.txt
index 5e876312b..a756607e3 100644
--- a/scripts/warning_docs.txt
+++ b/scripts/warning_docs.txt
@@ -1624,3 +1624,16 @@ module m;
     end
 endmodule
 ```
+
+-Winferred-latch
+A signal assigned in an always_comb procedure is not assigned on all control
+paths and so infers a latch instead of combinatorial logic.
+@options --disable-analysis=false
+```
+module m(input logic a, output logic b);
+    always_comb begin
+        if (a)
+            b = 0;
+    end
+endmodule
+```
diff --git a/source/analysis/AnalysisManager.cpp b/source/analysis/AnalysisManager.cpp
index 9ead2bd64..d0b546208 100644
--- a/source/analysis/AnalysisManager.cpp
+++ b/source/analysis/AnalysisManager.cpp
@@ -15,7 +15,7 @@ namespace slang::analysis {
 using namespace ast;
 
 const AnalyzedScope* AnalyzedInstance::getBody() const {
-    return analysisManager.getAnalyzedScope(symbol.body);
+    return analysisManager->getAnalyzedScope(symbol->body);
 }
 
 AnalysisManager::AnalysisManager(uint32_t numThreads) : threadPool(numThreads) {
diff --git a/source/analysis/AnalyzedProcedure.cpp b/source/analysis/AnalyzedProcedure.cpp
index 5d647e68b..8d7d78c62 100644
--- a/source/analysis/AnalyzedProcedure.cpp
+++ b/source/analysis/AnalyzedProcedure.cpp
@@ -131,7 +131,7 @@ static const TimingControl* inferClock(const ProceduralBlockSymbol& procedureSym
 
 AnalyzedProcedure::AnalyzedProcedure(AnalysisManager&, AnalysisContext& context,
                                      const ProceduralBlockSymbol& procedure) :
-    procedureSymbol(procedure) {
+    procedureSymbol(&procedure) {
 
     DataFlowAnalysis dfa(context, procedure);
     dfa.run(procedure.getBody());