Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker compose files on deploy does not have restart property #62

Open
dejanstrancar opened this issue Nov 10, 2024 · 2 comments
Open

Comments

@dejanstrancar
Copy link
Contributor

dejanstrancar commented Nov 10, 2024

When using Sidekick v.0.6.6 installed with brew generated docker-compose.yml file does include restart property. (restart: unless-stopped).

When doing it on same app from the github code source, it does include it.

Recreation:

Dockerfile

FROM node:20
WORKDIR /app
EXPOSE 3000

Brew installed sidekick v.0.6.6 version:
sidekick launch

Generated docker-compose.yml:

services:
    testing:
        image: testing
        labels:
            - traefik.enable=true
            - traefik.http.routers.testing.rule=Host(`testing.167.99.243.82.sslip.io`)
            - traefik.http.services.testing.loadbalancer.server.port=3000
            - traefik.http.routers.testing.tls=true
            - traefik.http.routers.testing.tls.certresolver=default
            - traefik.docker.network=sidekick
        networks:
            - sidekick
networks:
    sidekick:
        external: true

Github source running from source:

sidekick launch

Generated docker-compose.yml:

services:
    testing:
        image: testing
        restart: unless-stopped
        labels:
            - traefik.enable=true
            - traefik.http.routers.testing.rule=Host(`testing.167.99.243.82.sslip.io`)
            - traefik.http.services.testing.loadbalancer.server.port=3000
            - traefik.http.routers.testing.tls=true
            - traefik.http.routers.testing.tls.certresolver=default
            - traefik.docker.network=sidekick
        networks:
            - sidekick
networks:
    sidekick:
        external: true

Homebrew: 4.4.4
Sidekick: v0.6.6

@zeornelas
Copy link

Not sure if related with this issue but whenever the VPS restarts the containers are not being launched. If you have automatic maintenance on your VPS this can be problematic. @MightyMoud Should I open another issue for this bug/feature request?

@dejanstrancar
Copy link
Contributor Author

@zeornelas yes its related to this. This is how ive noticed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants