Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some small bugs? #1

Open
tycacz opened this issue Jul 24, 2017 · 1 comment
Open

Some small bugs? #1

tycacz opened this issue Jul 24, 2017 · 1 comment

Comments

@tycacz
Copy link

tycacz commented Jul 24, 2017

Hi Tomasz,
I have probably found some small bugs in your code. I hope that you will check it and maybe it will helps to you to improve your code. Please feel free to tell me if I'm wrong.
Best regards,
Martin Mostek
Ps: Thank You very much for your bootloader code, it helps me in my understanding of the STM Bootloader.

Bugs report:
In ExtendedErase function is wrong check sum :
/* checksum /
tx[6] = (byte)~ComputeChecksum(tx, 2, 5);
it should be:
/
checksum */
tx[6] = (byte)~ComputeChecksum(tx, 2, 4);

next (the same bug):
in EraseSpecial function is wrong check sum :
/* checksum /
tx[3] = (byte)~ComputeChecksum(tx, 2, 2);
it should be:
/
checksum */
tx[3] = (byte)~ComputeChecksum(tx, 2, 1);

and finally:
in ExtendedEraseSpecial function is wrong check sum :
/* checksum /
tx[4] = (byte)~ComputeChecksum(tx, 2, 3);
it should be:
/
checksum */
tx[4] = (byte)~ComputeChecksum(tx, 2, 2);

@josh2112
Copy link

josh2112 commented Apr 1, 2019

Hi tycacz,

Apparently the author has abandoned this project, but thanks for reporting these bugs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants