Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Allow an asset to have two markets in same pool, one as normal and one as protected collateral #381

Open
NikMidas opened this issue Sep 13, 2022 · 6 comments
Assignees

Comments

@NikMidas
Copy link
Collaborator

Allow an asset to have two markets in a pool, one as normal collateral (collateral and borrowable) and one as protected collateral (only collateral, not borrowable)

https://discord.com/channels/930077813585899561/981948177097846794/1014619036425912412

  • Refactor to reflect the discussion of enabling the depositor to specify the deposited asset is borrowable or not
  • Wrap one of the tokens before adding it to the pool
    - How do we show the differences between the assets in UI?

- Need to determine: Having a variable that determines a limit of how much of the collateral can be borrowable

@NikMidas
Copy link
Collaborator Author

Left Dom a comment on TG about this item, if this is something that needs to go on the Desired Features list

@NikMidas
Copy link
Collaborator Author

NikMidas commented Sep 27, 2022

Per Carlo, wrap underlying token if that underlying has already been added to the pool

@NikMidas
Copy link
Collaborator Author

Currently blocked by the diamond pattern issue

@NikMidas
Copy link
Collaborator Author

NikMidas commented Jan 3, 2023

@domfromhell Will come up with the UI, team will implement after

@peetzweg
Copy link
Contributor

peetzweg commented Jan 24, 2023

So whats the way to go for the UI? I personally don't see a benefit of adding a custom name to a market. We use the Token name for the market name. So it basically not the name of the market and more the underlying of the market. Changing that name artificially feels odd. Whats to gain here?

The markets with the same name can still be distinguished by their supply and apys etc. .

Image
Image

@NikMidas
Copy link
Collaborator Author

NikMidas commented Feb 7, 2023

Per Veliko, needs refactoring but lower priority for now due to Vault Factory work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants