Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nextcloud memories, Missing Line in nginx-nextcloud.conf #7192

Open
droogi opened this issue Aug 19, 2024 · 2 comments
Open

nextcloud memories, Missing Line in nginx-nextcloud.conf #7192

droogi opened this issue Aug 19, 2024 · 2 comments

Comments

@droogi
Copy link

droogi commented Aug 19, 2024

Creating a bug report/issue

  • [ x] I have searched the existing open and closed issues

Required Information

  • dietpi 9.6

Additional Information (if applicable)

  • nextcloud 29.0.4 and App memories

Steps to reproduce

Install nginx, nextcloud,nc App memories, lets-encrypt

Expected behaviour

Memories should Display thumbs and images

Actual behaviour

Thumbs are generated, but are Gray and images are Not displayed

Extra details

Solution is to add Line in /etc/nginx/sites-available/dietpi-nextcloud.conf

add_header Cross-Origin-Embedder-Policy credentialless;

I added It twice, IT works AS IT should now

pulsejet/memories#1236 (comment)

Regards, droogi

@droogi
Copy link
Author

droogi commented Aug 22, 2024

Maps Work again also (App Maps opened, but No layer was displayed)

@MichaIng
Copy link
Owner

Hmm, this does not seem to be supported widely among browsers, e.g. Safari and certain mobile browsers do not support it at all:

Isn't it possible to do all this with CSP? Nextcloud has an API for this, which can be used by apps, if I am not mistaken.

This does not seem suitable to add for all Nextcloud instances, also it should be probably added for the very specific URLs used by this app only, instead of disabling CORS entirely for the whole Nextcloud instance. This all can be done much better with CSP from the backend/app code, instead of globally via webserver configuration. I suggest you talk to its developer/maintainer about this.

Also, why did you add it twice?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants