Opening read-only floppy disk images

[CyberXZT]

Hi!

It appears ao486 attempts to open floppy disk images with read/write privileges, even when read-only is selected in the OSD menu. This fails when MiSTer only has read-only access to the disk image.

Ideally, the RW/RO choice should be passed to the filesystem and/or fall back to RO when RW is not available.

I think the specific line in question is here:
https://github.com/MiSTer-devel/Main_MiSTer/blob/master/support/x86/x86.cpp#L192

For reference, I am loading images off of a NAS via CIFS. Write permissions are disabled, where possible, in order to prevent accidental data loss.

Thanks!

[sorgelig]

Here: https://github.com/MiSTer-devel/Main_MiSTer/blob/e7ad487e895c617e680ba0329f05beb4613f3ae9/file_io.cpp#L717
It's checked twice for ability to write. I cannot test CIFS myself but If both checks are passed then somehow your server (or network subsystem) doesn't mark file as read-only.

[CyberXZT]

Yup, turns out permissions are not preserved through cifs. Here's my +1 for nfs support.

Thanks for your help!