Error during update

[mihalski]

======================================================================================
Hold your breath: updating the Kernel, the Linux filesystem, the bootloader and stuff.
Stopping this will make your SD unbootable!

If something goes wrong, please download the SD Installer from
https://github.com/MiSTer-devel/SD-Installer-Win64_MiSTer
and copy the content of the files/linux/ directory in the linux directory of the SD.
Reflash the bootloader with the SD Installer if needed.
======================================================================================

mv: cannot move '/media/fat/linux.update/files/linux/mt32-rom-data' to '/media/fat/linux/mt32-rom-data': File exists
mv: cannot move '/media/fat/linux.update/files/linux/soundfonts' to '/media/fat/linux/soundfonts': File exists

Erasing u-boot saved environment
1+0 records in
1+0 records out
512 bytes copied, 0.00089224 s, 574 kB/s

I just ran the update and this error popped up near the end. I've included the surrounding output for context. It was updating to the 20200122 release. It seems to work fine despite the error. Either a force, prompt or do not overwrite as default might be better.

[Locutus73]

Yeah, it's a false positive, I mean it's harmless.
The Linux release rar contains these two dirs with README files, but, since they are already in the SD (and probably populated with relevant stuff) they aren't moved. It's harmless, but I will see if I can avoid that.

[frederic-mahe]

May I suggest to use mv --force to get rid of the error messages (or mv --update to move only when SOURCE is newer than DEST)?

mv SOURCE DEST > /dev/null 2>&1
# could be replaced with:
mv -f SOURCE DEST

similarly, rm DEST > /dev/null 2>&1 can be replaced with rm -f DEST.

Finally, pairs of rm + mv can be replaced by a single mv -f:

rm DEST > /dev/null 2>&1
mv SOURCE DEST > /dev/null 2>&1
# could be replaced with:
mv -f SOURCE DEST