Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nifty git PR+merge commit #7

Open
dandv opened this issue Nov 30, 2014 · 4 comments
Open

Nifty git PR+merge commit #7

dandv opened this issue Nov 30, 2014 · 4 comments

Comments

@dandv
Copy link
Member

dandv commented Nov 30, 2014

Hey @davidsonfellipe, how did you do this ?

@davidsonfellipe
Copy link

@dandv I deleted my fork.

@dandv
Copy link
Member Author

dandv commented Nov 30, 2014

Hm. I've deleted my fork too but that didn't result in that sort of nice history.

@dandv
Copy link
Member Author

dandv commented Dec 1, 2014

Hey @ichernev, how did you do this on Nov 17? I've just deleted the branch you've just merged, but that didn't result in a compact commit.

@dandv dandv changed the title Nifty git commit Nifty git PR+merge commit Dec 1, 2014
@ichernev
Copy link

ichernev commented Dec 1, 2014

The history you see in github commits does not show the branching. My current merge strategy is to wait until I want to release, then I start pulling the code from all PRs, rebase on top of develop (might edit manually some commits to make them fit) and then merge. I have a script that does all that, allowing me to edit if stuff goes wrong.

The small photo of me is because I edited the commits, but I'm not the original author.

Also you shouldn't merge the PR commit with the merge -- there should be a merge commit.

Do this to check out the real history:

git log --graph --decorate --pretty=oneline --abbrev-commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants