Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isotope discussion Program3r <-> dandv #1

Open
dandv opened this issue Nov 29, 2014 · 5 comments
Open

Isotope discussion Program3r <-> dandv #1

dandv opened this issue Nov 29, 2014 · 5 comments

Comments

@dandv
Copy link
Member

dandv commented Nov 29, 2014

Hey @Program3r, let's move this discussion here, since it got quite specific.

Here's my package code for bundling up and testing Isotope

To be honest, I've read through docs.meteor.com and Differential's dissection of the Package api and don't understand exactly what versionsFrom does.

If no version is specified for an 'api.use' dependency, use the one defined in [parameter]

That doesn't suggest that if a package has api.use('0.9.0'), it can't be used with newer Meteor apps, as you seemed to imply:

Thanks for upgrading your (from official) package to 1.0 so it can be used in new meteor apps.

@Program3r
Copy link

I just re-tested this and it was an issue with my (docker) container. I created a new one and was able to use 0.9.3 packages in a 1.0 application. versionFrom is supposed to control what core packages are loaded based on that version of Meteor you lock in. I assumed from the behavior of my container that it was locking applications to the version of that package by not resolving versions correctly. I've since violently deleted that container. I don't have the issue anymore.

@dandv
Copy link
Member Author

dandv commented Nov 29, 2014

"violently deleted* :-)

  1. Is it accurate that if there are no api.use() calls in a Package.onUse() then, api.versionFrom is irrelevant?
  2. Is it accurate that api.versionFrom() only impacts api.use() calls for core packages?

@Program3r
Copy link

  1. I wouldn't say it's irrelevant completely, if an a API of a core package gets changed that you didn't specify with api.use() (or use versionFrom instead) but are using anyway (like jquery/spacebars/blaze) then your application would use the new version right away when your package is used in an updated meteor install. It could cause things to break.

  2. Yes, it only impacts core packages.

@dandv
Copy link
Member Author

dandv commented Nov 29, 2014

Thank you. Let's say jquery is used. What versionsFrom parameter would ensure compatibility with the largest number of current Meteor packages? Maybe specify all of them, as autoform does?

@dandv
Copy link
Member Author

dandv commented Nov 30, 2014

Actually an explicit [email protected] causes breakage on Windows.

package.js:

Package.onUse(function (api) {
  api.versionsFrom('[email protected]');
  api.use([
    'jquery',
    'twbs:[email protected]',
    'fortawesome:[email protected]'
  ], where);
C:\prg\met\test>meteor add summernote:summernote
Could not satisfy all the specified constraints:
Error: conflict: constraint [email protected] is not satisfied by 1.0.1-win.0.
Constraints on jquery come from:
  <top level>
  [email protected]
  [email protected] -> [email protected]
  summernote:[email protected]

C:\prg\met\test>meteor add summernote:[email protected]
Could not satisfy all the specified constraints:
Error: conflict: constraint [email protected] is not satisfied by 1.0.1-win.0.
Constraints on jquery come from:
  <top level>
  [email protected]
  [email protected] -> [email protected]
  summernote:[email protected]

If I change package.js to api.versionsFrom('[email protected]'); then the package installs fine:

C:\prg\met\test>meteor add summernote:summernote-compat
   added summernote:summernote-compat at version 0.6.0
   added twbs:bootstrap at version 3.3.1
   added fortawesome:fontawesome at version 4.2.0

summernote:summernote-compat: summernote (official): jQuery+Bootstrap+FontAwesome WYSIWYG editor with embedded images support

The magic bullet seems to be

api.versionsFrom(['[email protected]', '[email protected]']);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants