FR: Item persister and retriever #1097

zonky2 · 2017-03-17T07:38:14Z

Check https://github.com/MetaModels/core/tree/feature/item-persister-and-retriever

zonky2 · 2017-03-17T07:40:49Z

dev-feature/item-persister-and-retriever (b63bd7e)

Update or New and save item at BE:

Warning: sprintf(): Too few arguments in composer\vendor\metamodels\core\src\MetaModels\DataAccess\ItemPersister.php on line 218

#0 [internal function]: __error(2, 'sprintf(): Too ...', 'C:\\Contao2Go\\ht...', 218, Array)
#1 composer\vendor\metamodels\core\src\MetaModels\DataAccess\ItemPersister.php(218): sprintf('UPDATE %1$s %%s...', 'mm_mitarbeiterl...', '?')
#2 composer\vendor\metamodels\core\src\MetaModels\DataAccess\ItemPersister.php(99): MetaModels\DataAccess\ItemPersister->saveRawColumns(Array, Array)
#3 composer\vendor\metamodels\core\src\MetaModels\MetaModel.php(429): MetaModels\DataAccess\ItemPersister->saveItem(Object(MetaModels\Item))
#4 composer\vendor\metamodels\core\src\MetaModels\Item.php(324): MetaModels\MetaModel->saveItem(Object(MetaModels\Item))
#5 composer\vendor\metamodels\core\src\MetaModels\DcGeneral\Data\Driver.php(582): MetaModels\Item->save()
#6 composer\vendor\contao-community-alliance\dc-general\src\ContaoCommunityAlliance\DcGeneral\Contao\View\Contao2BackendView\EditMask.php(630): MetaModels\DcGeneral\Data\Driver->save(Object(MetaModels\DcGeneral\Data\Model))
#7 composer\vendor\contao-community-alliance\dc-general\src\ContaoCommunityAlliance\DcGeneral\Contao\View\Contao2BackendView\EditMask.php(725): ContaoCommunityAlliance\DcGeneral\Contao\View\Contao2BackendView\EditMask->doPersist()
#8 composer\vendor\contao-community-alliance\dc-general\src\ContaoCommunityAlliance\DcGeneral\Contao\View\Contao2BackendView\ActionHandler\EditHandler.php(76): ContaoCommunityAlliance\DcGeneral\Contao\View\Contao2BackendView\EditMask->execute()
#9 composer\vendor\contao-community-alliance\dc-general\src\ContaoCommunityAlliance\DcGeneral\View\ActionHandler\AbstractHandler.php(54): ContaoCommunityAlliance\DcGeneral\Contao\View\Contao2BackendView\ActionHandler\EditHandler->process()
#10 [internal function]: ContaoCommunityAlliance\DcGeneral\View\ActionHandler\AbstractHandler->handleEvent(Object(ContaoCommunityAlliance\DcGeneral\Event\ActionEvent), 'dc-general.acti...', Object(Symfony\Component\EventDispatcher\EventDispatcher))
#11 composer\vendor\symfony\event-dispatcher\EventDispatcher.php(184): call_user_func(Array, Object(ContaoCommunityAlliance\DcGeneral\Event\ActionEvent), 'dc-general.acti...', Object(Symfony\Component\EventDispatcher\EventDispatcher))
#12 composer\vendor\symfony\event-dispatcher\EventDispatcher.php(46): Symfony\Component\EventDispatcher\EventDispatcher->doDispatch(Array, 'dc-general.acti...', Object(ContaoCommunityAlliance\DcGeneral\Event\ActionEvent))
#13 composer\vendor\contao-community-alliance\dc-general\src\ContaoCommunityAlliance\DcGeneral\Controller\DefaultController.php(152): Symfony\Component\EventDispatcher\EventDispatcher->dispatch('dc-general.acti...', Object(ContaoCommunityAlliance\DcGeneral\Event\ActionEvent))
#14 composer\vendor\metamodels\core\src\MetaModels\BackendIntegration\Module.php(74): ContaoCommunityAlliance\DcGeneral\Controller\DefaultController->handle(Object(ContaoCommunityAlliance\DcGeneral\Action))
#15 system\modules\core\classes\Backend.php(423): MetaModels\BackendIntegration\Module->generate()
#16 system\modules\core\controllers\BackendMain.php(131): Contao\Backend->getBackendModule('metamodel_mm_mi...')
#17 contao\main.php(20): Contao\BackendMain->run()
#18 {main}


Fatal error: Uncaught exception Exception with message Empty query string thrown in system\modules\core\library\Contao\Database\Statement.php on line 145

#0 system\modules\core\library\Contao\Database.php(181): Contao\Database\Statement->prepare(false)
#1 composer\vendor\metamodels\core\src\MetaModels\DataAccess\ItemPersister.php(219): Contao\Database->prepare(false)
#2 composer\vendor\metamodels\core\src\MetaModels\DataAccess\ItemPersister.php(99): MetaModels\DataAccess\ItemPersister->saveRawColumns(Array, Array)
#3 composer\vendor\metamodels\core\src\MetaModels\MetaModel.php(429): MetaModels\DataAccess\ItemPersister->saveItem(Object(MetaModels\Item))
#4 composer\vendor\metamodels\core\src\MetaModels\Item.php(324): MetaModels\MetaModel->saveItem(Object(MetaModels\Item))
#5 composer\vendor\metamodels\core\src\MetaModels\DcGeneral\Data\Driver.php(582): MetaModels\Item->save()
#6 composer\vendor\contao-community-alliance\dc-general\src\ContaoCommunityAlliance\DcGeneral\Contao\View\Contao2BackendView\EditMask.php(630): MetaModels\DcGeneral\Data\Driver->save(Object(MetaModels\DcGeneral\Data\Model))
#7 composer\vendor\contao-community-alliance\dc-general\src\ContaoCommunityAlliance\DcGeneral\Contao\View\Contao2BackendView\EditMask.php(725): ContaoCommunityAlliance\DcGeneral\Contao\View\Contao2BackendView\EditMask->doPersist()
#8 composer\vendor\contao-community-alliance\dc-general\src\ContaoCommunityAlliance\DcGeneral\Contao\View\Contao2BackendView\ActionHandler\EditHandler.php(76): ContaoCommunityAlliance\DcGeneral\Contao\View\Contao2BackendView\EditMask->execute()
#9 composer\vendor\contao-community-alliance\dc-general\src\ContaoCommunityAlliance\DcGeneral\View\ActionHandler\AbstractHandler.php(54): ContaoCommunityAlliance\DcGeneral\Contao\View\Contao2BackendView\ActionHandler\EditHandler->process()
#10 [internal function]: ContaoCommunityAlliance\DcGeneral\View\ActionHandler\AbstractHandler->handleEvent(Object(ContaoCommunityAlliance\DcGeneral\Event\ActionEvent), 'dc-general.acti...', Object(Symfony\Component\EventDispatcher\EventDispatcher))
#11 composer\vendor\symfony\event-dispatcher\EventDispatcher.php(184): call_user_func(Array, Object(ContaoCommunityAlliance\DcGeneral\Event\ActionEvent), 'dc-general.acti...', Object(Symfony\Component\EventDispatcher\EventDispatcher))
#12 composer\vendor\symfony\event-dispatcher\EventDispatcher.php(46): Symfony\Component\EventDispatcher\EventDispatcher->doDispatch(Array, 'dc-general.acti...', Object(ContaoCommunityAlliance\DcGeneral\Event\ActionEvent))
#13 composer\vendor\contao-community-alliance\dc-general\src\ContaoCommunityAlliance\DcGeneral\Controller\DefaultController.php(152): Symfony\Component\EventDispatcher\EventDispatcher->dispatch('dc-general.acti...', Object(ContaoCommunityAlliance\DcGeneral\Event\ActionEvent))
#14 composer\vendor\metamodels\core\src\MetaModels\BackendIntegration\Module.php(74): ContaoCommunityAlliance\DcGeneral\Controller\DefaultController->handle(Object(ContaoCommunityAlliance\DcGeneral\Action))
#15 system\modules\core\classes\Backend.php(423): MetaModels\BackendIntegration\Module->generate()
#16 system\modules\core\controllers\BackendMain.php(131): Contao\Backend->getBackendModule('metamodel_mm_mi...')
#17 contao\main.php(20): Contao\BackendMain->run()
#18 {main}

at New we have an empty new item

zonky2 · 2017-03-17T07:46:52Z

published/unpublished per "green eye" doesn´t works - Ajax send same error as #1097 (comment)

zonky2 · 2017-03-17T11:29:59Z

after MM update:

Update or New and save item at BE:


#0 system\modules\core\library\Contao\Database\Statement.php(262): Contao\Database\Statement->replaceWildcards(Array)
#1 composer\vendor\metamodels\core\src\MetaModels\DataAccess\ItemPersister.php(221): Contao\Database\Statement->execute(Array)
#2 composer\vendor\metamodels\core\src\MetaModels\DataAccess\ItemPersister.php(99): MetaModels\DataAccess\ItemPersister->saveRawColumns(Array, Array)
#3 composer\vendor\metamodels\core\src\MetaModels\MetaModel.php(429): MetaModels\DataAccess\ItemPersister->saveItem(Object(MetaModels\Item))
#4 composer\vendor\metamodels\core\src\MetaModels\Item.php(324): MetaModels\MetaModel->saveItem(Object(MetaModels\Item))
#5 composer\vendor\metamodels\core\src\MetaModels\DcGeneral\Data\Driver.php(582): MetaModels\Item->save()
#6 composer\vendor\contao-community-alliance\dc-general\src\ContaoCommunityAlliance\DcGeneral\Contao\View\Contao2BackendView\EditMask.php(630): MetaModels\DcGeneral\Data\Driver->save(Object(MetaModels\DcGeneral\Data\Model))
#7 composer\vendor\contao-community-alliance\dc-general\src\ContaoCommunityAlliance\DcGeneral\Contao\View\Contao2BackendView\EditMask.php(725): ContaoCommunityAlliance\DcGeneral\Contao\View\Contao2BackendView\EditMask->doPersist()
#8 composer\vendor\contao-community-alliance\dc-general\src\ContaoCommunityAlliance\DcGeneral\Contao\View\Contao2BackendView\ActionHandler\EditHandler.php(76): ContaoCommunityAlliance\DcGeneral\Contao\View\Contao2BackendView\EditMask->execute()
#9 composer\vendor\contao-community-alliance\dc-general\src\ContaoCommunityAlliance\DcGeneral\View\ActionHandler\AbstractHandler.php(54): ContaoCommunityAlliance\DcGeneral\Contao\View\Contao2BackendView\ActionHandler\EditHandler->process()
#10 [internal function]: ContaoCommunityAlliance\DcGeneral\View\ActionHandler\AbstractHandler->handleEvent(Object(ContaoCommunityAlliance\DcGeneral\Event\ActionEvent), 'dc-general.acti...', Object(Symfony\Component\EventDispatcher\EventDispatcher))
#11 composer\vendor\symfony\event-dispatcher\EventDispatcher.php(184): call_user_func(Array, Object(ContaoCommunityAlliance\DcGeneral\Event\ActionEvent), 'dc-general.acti...', Object(Symfony\Component\EventDispatcher\EventDispatcher))
#12 composer\vendor\symfony\event-dispatcher\EventDispatcher.php(46): Symfony\Component\EventDispatcher\EventDispatcher->doDispatch(Array, 'dc-general.acti...', Object(ContaoCommunityAlliance\DcGeneral\Event\ActionEvent))
#13 composer\vendor\contao-community-alliance\dc-general\src\ContaoCommunityAlliance\DcGeneral\Controller\DefaultController.php(152): Symfony\Component\EventDispatcher\EventDispatcher->dispatch('dc-general.acti...', Object(ContaoCommunityAlliance\DcGeneral\Event\ActionEvent))
#14 composer\vendor\metamodels\core\src\MetaModels\BackendIntegration\Module.php(74): ContaoCommunityAlliance\DcGeneral\Controller\DefaultController->handle(Object(ContaoCommunityAlliance\DcGeneral\Action))
#15 system\modules\core\classes\Backend.php(423): MetaModels\BackendIntegration\Module->generate()
#16 system\modules\core\controllers\BackendMain.php(131): Contao\Backend->getBackendModule('metamodel_mm_mi...')
#17 contao\main.php(20): Contao\BackendMain->run()
#18 {main}

zonky2 · 2017-03-17T13:40:08Z

https://github.com/MetaModels/core/blob/feature/item-persister-and-retriever/src/MetaModels/DataAccess/ItemPersister.php#L215

-                    'UPDATE %1$s %%s=? WHERE id IN (%2$s)',
+                    'UPDATE %1$s %%s WHERE id IN (%2$s)',

zonky2 · 2017-03-17T22:08:06Z

it´s not possible to work with variants

parent override all variant values at childs at save - only alias works fine
https://github.com/MetaModels/core/blob/feature/item-persister-and-retriever/src/MetaModels/DataAccess/ItemPersister.php#L108

-$variantIds = [];
+$variantIds = [$itemId];

zonky2 · 2017-03-28T09:37:55Z

@discordier have you a new strategy for vatiants?

note: #871

discordier · 2017-04-19T16:03:47Z

Not yet, however we should implement it in here.

discordier · 2017-04-19T16:53:50Z

please follow ups to #1112

zonky2 added the enhancement This issue is about an enhancement (aka new feature) label Mar 17, 2017

zonky2 added this to the 2.0.0 milestone Mar 17, 2017

zonky2 assigned discordier Mar 17, 2017

discordier added a commit that referenced this issue Mar 17, 2017

Fix #1097 correct parameter index in query

80a2e30

discordier added a commit that referenced this issue Mar 17, 2017

Fix #1097 correct parameter values in query

5d1847d

zonky2 added the bug A bug! A bug! Fast, squish it! label Mar 18, 2017

discordier added a commit that referenced this issue Apr 19, 2017

Fix #1097 correct parameter index in query

6ac9da9

discordier added a commit that referenced this issue Apr 19, 2017

Fix #1097 correct parameter values in query

f21ba95

discordier closed this as completed Apr 19, 2017

zonky2 mentioned this issue Apr 19, 2017

[WIP] Feature/item persister and retriever #1112

Open

6 tasks

discordier added a commit that referenced this issue May 30, 2017

Fix #1097 correct parameter index in query

7e6a939

discordier added a commit that referenced this issue May 30, 2017

Fix #1097 correct parameter values in query

6f86ca4

discordier added a commit that referenced this issue Mar 6, 2018

Fix #1097 correct parameter index in query

bd61c41

discordier added a commit that referenced this issue Mar 6, 2018

Fix #1097 correct parameter values in query

1b3df30

discordier added a commit that referenced this issue Mar 10, 2018

Fix #1097 correct parameter index in query

fc34f9c

discordier added a commit that referenced this issue Mar 10, 2018

Fix #1097 correct parameter values in query

4605229

discordier added a commit that referenced this issue Mar 10, 2018

Fix #1097 correct parameter index in query

5b7f658

discordier added a commit that referenced this issue Mar 10, 2018

Fix #1097 correct parameter values in query

263faeb

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FR: Item persister and retriever #1097

FR: Item persister and retriever #1097

zonky2 commented Mar 17, 2017

zonky2 commented Mar 17, 2017 •

edited

Loading

zonky2 commented Mar 17, 2017

zonky2 commented Mar 17, 2017 •

edited

Loading

zonky2 commented Mar 17, 2017

zonky2 commented Mar 17, 2017 •

edited

Loading

zonky2 commented Mar 28, 2017 •

edited

Loading

discordier commented Apr 19, 2017

discordier commented Apr 19, 2017

FR: Item persister and retriever #1097

FR: Item persister and retriever #1097

Comments

zonky2 commented Mar 17, 2017

zonky2 commented Mar 17, 2017 • edited Loading

zonky2 commented Mar 17, 2017

zonky2 commented Mar 17, 2017 • edited Loading

zonky2 commented Mar 17, 2017

zonky2 commented Mar 17, 2017 • edited Loading

zonky2 commented Mar 28, 2017 • edited Loading

discordier commented Apr 19, 2017

discordier commented Apr 19, 2017

zonky2 commented Mar 17, 2017 •

edited

Loading

zonky2 commented Mar 17, 2017 •

edited

Loading

zonky2 commented Mar 17, 2017 •

edited

Loading

zonky2 commented Mar 28, 2017 •

edited

Loading