Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: @metamask/rpc-errors@^6.3.1->^7.0.0 #2817

Closed
wants to merge 8 commits into from

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Oct 9, 2024


Open question

Currently snaps-rpc-methods tests fail because some errors now have the new (old) behavior of not wrapping error messages.

Haven't figured out if there is something else at play as well/instead but looks like at least @metamask/json-rpc-engine calls serializeError with default arguments which are not currently overridable (though that dependency is still on v6 so TBD)

If the above is correct, which of these options are preferred?

  1. Add/rewrite middleware in snaps to handle this
  2. Add constructor option to JsonRpcEngine to allow overriding serializeError options
  3. Rewrite tests in snaps-rpc-methods to accomodate to new defaults

Related

Copy link

socket-security bot commented Oct 9, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] network +10 995 kB metamaskbot
npm/@metamask/[email protected] None +5 691 kB metamaskbot

🚮 Removed packages: npm/@metamask/[email protected], npm/@metamask/[email protected]

View full report↗︎

@legobeat legobeat mentioned this pull request Oct 9, 2024
@FrederikBolding
Copy link
Member

Done in #2853

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants