Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Fix permission-system-revoking-multiple-accounts.spec.js Detox test #11366

Closed
SamuelSalas opened this issue Sep 21, 2024 · 0 comments · Fixed by #11367
Closed

[Bug]: Fix permission-system-revoking-multiple-accounts.spec.js Detox test #11366

SamuelSalas opened this issue Sep 21, 2024 · 0 comments · Fixed by #11367
Assignees
@SamuelSalas
Labels
Detox regression-prod-7.31.0 Regression bug that was found in production in release 7.31.0 release-7.33.0 Issue or pull request that will be included in release 7.33.0 team-mobile-platform type-bug Something isn't working

Comments

@SamuelSalas
Copy link
Member

Describe the bug

Currently, e2e/specs/permission-systems/permission-system-revoking-multiple-accounts.spec.js is failing on main. Some of the methods used on some steps were changed in a previous PR. But they spec was not updated as expected, so the test failed because is unable to find those methods.

Expected behavior

All test should pass

Screenshots/Recordings

No response

Steps to reproduce

Run pr_regression_e2e_pipeline

Error messages or log output

No response

Detection stage

In production (default)

Version

7.31.0

Build type

None

Device

iPhone 15 Pro

Operating system

Other (please elaborate in the "Additional Context" section)

Additional context

Both ios and Android

Severity

No response
@SamuelSalas SamuelSalas added type-bug Something isn't working Detox labels Sep 21, 2024
@metamaskbot metamaskbot added the regression-prod-7.31.0 Regression bug that was found in production in release 7.31.0 label Sep 21, 2024
@SamuelSalas SamuelSalas linked a pull request Sep 21, 2024 that will close this issue
fix: Update steps of the methods that are no longer valid #11367
Merged
7 tasks
@SamuelSalas SamuelSalas self-assigned this Sep 24, 2024
@metamaskbot metamaskbot added the release-7.33.0 Issue or pull request that will be included in release 7.33.0 label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SamuelSalas SamuelSalas

Labels
Detox regression-prod-7.31.0 Regression bug that was found in production in release 7.31.0 release-7.33.0 Issue or pull request that will be included in release 7.33.0 team-mobile-platform type-bug Something isn't working
Projects
Bugs by severity
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Update steps of the methods that are no longer valid MetaMask/metamask-mobile
3 participants
@SamuelSalas @metamaskbot @anaamolnar