Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Test Snap Get File test snap_getFile functionality" flaky tests #27276

Open
hjetpoluru opened this issue Sep 19, 2024 · 1 comment
Open
Labels
flaky tests Sev2-normal Normal severity; minor loss of service or inconvenience. team-snaps DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead type-bug

Comments

@hjetpoluru
Copy link
Contributor

https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/101097/workflows/11c190ee-691c-4d05-9fbb-8c9a8f2125ad/jobs/3763990/tests

Build - Regular
Browser - Chrome
Test Path - /test/e2e/snaps/test-snap-get-file.spec.js
Test Scenario - Test Snap Get File test snap_getFile functionality

Error: Timeout of 80000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/circleci/project/test/e2e/snaps/test-snap-get-file.spec.js)
    at listOnTimeout (node:internal/timers:581:17)
    at process.processTimers (node:internal/timers:519:7)
@hjetpoluru hjetpoluru added type-bug Sev2-normal Normal severity; minor loss of service or inconvenience. team-extension-platform flaky tests labels Sep 19, 2024
@chloeYue chloeYue added team-snaps DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead and removed team-extension-platform labels Sep 27, 2024
@bowensanders
Copy link
Contributor

bowensanders commented Sep 30, 2024

Diving in to this particular flake above, you find this:

Executing testcase: 'test snap_getFile functionality'
2024-09-18T15:35:22.336Z [driver] Called 'navigate' with arguments []
2024-09-18T15:35:25.331Z [driver] Called 'fill' with arguments ["#password","correct horse battery staple"]
2024-09-18T15:35:25.613Z [driver] Called 'press' with arguments ["#password",""]
2024-09-18T15:35:25.642Z [driver] Called 'assertElementNotPresent' with arguments ["[data-testid=\"unlock-page\"]"]
ServerMochaToBackground got a client connection
Failure on testcase: 'test snap_getFile functionality', for more information see the artifacts tab in CI
Error: Found element "[data-testid=\"unlock-page\"]" that should not be present

This error is happening at the connecting / opening of metamask and not during the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky tests Sev2-normal Normal severity; minor loss of service or inconvenience. team-snaps DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead type-bug
Projects
Status: To be fixed
Status: To be fixed
Development

No branches or pull requests

3 participants