Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Gas - TypeError: Cannot set properties of undefined (setting 'gasFeeEstimates') #27241

Open
seaona opened this issue Sep 18, 2024 · 3 comments
Labels
regression-RC-12.3.0 Regression bug that was found in release candidate (RC) for release 12.3.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations Push issues to confirmations team type-bug

Comments

@seaona
Copy link
Contributor

seaona commented Sep 18, 2024

Describe the bug

Background error TypeError: Cannot set properties of undefined (setting 'gasFeeEstimates'). I haven't seen any UI impact, but cannot reproduce again, to be able to add more details

Expected behavior

No response

Screenshots/Recordings

Screenshot from 2024-09-18 10-59-46

Steps to reproduce

To determine.

I was using 2 networks for 2 different dapps (Sepolia and Linea Sepolia) and switching back and forth triggering txs.

Error messages or log output

No response

Detection stage

During release testing

Version

12.3.0

Build type

None

Browser

Chrome

Operating system

Linux

Hardware wallet

No response

Additional context

No response

Severity

No response

@metamaskbot metamaskbot added the regression-RC-12.3.0 Regression bug that was found in release candidate (RC) for release 12.3.0 label Sep 18, 2024
@gauthierpetetin gauthierpetetin added team-confirmations Push issues to confirmations team Sev2-normal Normal severity; minor loss of service or inconvenience. labels Sep 19, 2024
@cryptotavares
Copy link
Contributor

@seaona if you cannot reproduce should we close it?

@seaona
Copy link
Contributor Author

seaona commented Oct 3, 2024

I've just encountered it again in 12.3.0 and I've seen that there are more than 90k entries for this error in Sentry. So I think that investigating repro steps and trying to address it would definitely help reducing Sentry errors.

Screenshot from 2024-10-03 11-42-05

We could open the Sentry issue too if that's more helpful to link data, and get more debugging info. What do you think?

Screenshot from 2024-10-03 11-40-02

@seaona
Copy link
Contributor Author

seaona commented Nov 4, 2024

Found some repro steps cc @cryptotavares :

Repro:

  1. Setup proxy (ie Burpsuite)
  2. Intercept the gas.api.cx.metamask.io requests
  3. Start a Send flow
  4. Leave all the gas API requests unresolved
  5. Go to the last confirmation screen
  6. Wait a couple of seconds
  7. Open the Edit gas
  8. See how gas is trying to refresh
  9. Confirm tx
  10. See background error
gasEstimates-undefined.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-RC-12.3.0 Regression bug that was found in release candidate (RC) for release 12.3.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations Push issues to confirmations team type-bug
Projects
Status: To be fixed
Status: To be fixed
Development

No branches or pull requests

4 participants