Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Can't change network #23537

Closed
BrilliantPy opened this issue Mar 17, 2024 · 13 comments
Closed

[Bug]: Can't change network #23537

BrilliantPy opened this issue Mar 17, 2024 · 13 comments
Assignees
Labels
external-contributor needs-reproduction regression-prod-11.12.0 Regression bug that was found in production in release 11.12.0 Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. team-extension-platform type-bug

Comments

@BrilliantPy
Copy link

Describe the bug

After I changed the rpc of the base chain from this website. https://chainlist.org/?search=base
My metamask shows network as "?" and when I click on network to change to another network, you will see the error page as shown in the picture. Now I can't login. Because after logging in, you will see an error page and cannot do anything else. I don't want to delete and reinstall. Because there are some accounts that I imported and didn't write down the private key, how can I solve this problem? Thanks for all the advice.

Screenshot 2024-03-16 013119

Screenshot 2024-03-17 143213

Screenshot 2024-03-16 004841

Expected behavior

No response

Screenshots/Recordings

No response

Steps to reproduce

connect the wallet
Change new rpc for base network >> https://chainlist.org/?search=base
The extension shows a rotating icon as if it's connected. and show the error page
Then, where you want to change the network, it always shows "?" and when you press it, it will bring up an error page every time.

Error messages or log output

No response

Version

11.12.0

Build type

None

Browser

Chrome

Operating system

Windows

Hardware wallet

No response

Additional context

No response

Severity

No response

@metamaskbot metamaskbot added external-contributor regression-prod-11.12.0 Regression bug that was found in production in release 11.12.0 labels Mar 17, 2024
@danjm
Copy link
Contributor

danjm commented Mar 19, 2024

@BrilliantPy Can you toggle open "Error details" on the error screen, and take a screen shot of the error information that is shown?

@anaamolnar anaamolnar added the needs-information Needs additional information from the user who reported the issue label Mar 19, 2024
@BrilliantPy
Copy link
Author

Screenshot 2024-03-21 234922
Screenshot 2024-03-21 234858

@BrilliantPy
Copy link
Author

Screenshot 2024-03-21 235628
Screenshot 2024-03-21 235949
Screenshot 2024-03-22 000010

@anaamolnar
Copy link

Hello, @BrilliantPy. Thanks for reporting! Can you attempt to trigger a network request from chainlist.org using a different RPC URL (by pressing the arrow under Add network)? Please also make sure your Metamask is updated to the latest version. You will be able to manually update it from your browser. Go to extensions-> Metamask->Details->Enable developer mode from the top right, then there should be a button for Updating in the top left. Please let me know how it goes.

@BrilliantPy
Copy link
Author

If I press the change network button, I get an error page and can't press any more buttons.
And if login The metamask window will show an error immediately. Therefore, whether you press to change the chain from chainlist, you will only see an error page. P.S. I updated to the latest version 11.13.0 but the problem still cannot be solved. please help me

@anaamolnar
Copy link

Hey @BrilliantPy, I understand, thanks for the information. Does it still behave like this if you change these settings? https://support.metamask.io/hc/en-us/articles/360038139452-MetaMask-states-Balance-may-be-outdated-displays-in-orange-or-ETH-not-added-to-balance

@gauthierpetetin
Copy link
Contributor

gauthierpetetin commented Apr 12, 2024

@danjm do you have any idea which of these Sentry issue(s) corresponds to this?

@gauthierpetetin gauthierpetetin added Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. team-extension-platform labels Apr 12, 2024
@Gudahtt
Copy link
Member

Gudahtt commented May 30, 2024

From looking at the stack trace, the "Cannot read properties of undefined (reading 'id')" error appears to come from this line:

@Gudahtt
Copy link
Member

Gudahtt commented May 30, 2024

Without a reproduction, it's hard to say exactly what happened here. I can't find any similar reports in Sentry either. But it appears that this is a case of state corruption; somehow your providerConfig state refers to a network that doesn't exist in your networkConfigurations state.

@BrilliantPy sorry for the delay in replying here. Are you still stuck on this error? I might be able to suggest a hacky solution to get past this problem (delete the problematic state and restart the extension)

@Gudahtt Gudahtt added needs-reproduction and removed needs-information Needs additional information from the user who reported the issue labels May 30, 2024
@Gudahtt
Copy link
Member

Gudahtt commented May 30, 2024

For now I'm going to close this, as we cannot reproduce it and have not had similar reports. But @BrilliantPy please reach out if you're still stuck, and we will help you resolve the problem and recover your accounts. Please tag me so that I don't miss the notification.

@Gudahtt Gudahtt closed this as completed May 30, 2024
@Gudahtt
Copy link
Member

Gudahtt commented May 30, 2024

As far as preventing this in the future; there is a refactor of wallet state that is being worked on now that that would prevent this (providerConfig is getting eliminated, so it will be impossible for it to become out-of-sync, see this PR).

@Gudahtt Gudahtt self-assigned this May 30, 2024
@benjisclowder
Copy link
Contributor

Collaborative Effort Required for Root Cause Analysis (RCA) on Critical Issues

We are quickly approaching the end of the quarter and we encourage you once again to take some moments and perform RCA on this critical issue. You may do so by answering the questions below:

What PR fixed the issue?
Can you pinpoint the commit from which the issue originated?
Write a short explanation of the technical cause of the bug
How could we have avoided merging this bug? What would have had to be different about our code, tests or processes?
4.1. Were there any missing unit, e2e or manual tests that could have preempted this issue?
4.2. Were there any other elements lacking, such as typed code, comprehensive documentation, well-architected APIs, etc., that might have prevented this issue?
4.3. If your answer to a and b is no, then is there anything at all that you can think of that, if it had been different before this bug was introduced, would have prevented it from being merged?
Please provide your answers as a reply to this comment and tag me as well.

You can read more about the initiative here. Thank you!

cc: @Gudahtt only if you believe this issue can be RCA'd.

@Gudahtt
Copy link
Member

Gudahtt commented Jul 15, 2024

@benjisclowder This bug was not fixed, it was closed because we were unable to reproduce it. Probably we can skip the RCA in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-contributor needs-reproduction regression-prod-11.12.0 Regression bug that was found in production in release 11.12.0 Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. team-extension-platform type-bug
Projects
Archived in project
Development

No branches or pull requests

7 participants