Cleanup console logs

Author: darkwing

app/scripts/metamask-controller.js

@@ -1993,24 +1993,12 @@ export default class MetamaskController extends EventEmitter {
   }
 
   async checkLedgerReady(address) {
-    console.log('checkLedgerReady; called for address: ', address);
-
     const keyring = await this.keyringController.getKeyringForAccount(address);
-
-    console.log('checkLedgerReady; keyring is: ', keyring);
     if (!keyring) {
       throw new Error('No keyring could be found for this address');
     }
 
     const isReady = Boolean(keyring?.isConnected?.());
-
-    console.log(
-      '[checkLedgerReady] keyring is: ',
-      keyring,
-      '; isReady: ',
-      isReady,
-    );
-
     return isReady;
   }
 

ui/pages/confirm-transaction-base/confirm-transaction-base.component.js

@@ -167,41 +167,23 @@ export default class ConfirmTransactionBase extends Component {
     const { fromAddress } = this.props;
     const { pollingIntervalId } = this.state;
 
-    console.log(
-      '[confirm-transaction-base] pollLedgerReadycalled; id: ',
-      pollingIntervalId,
-    );
-
     // Don't set off multiple calls to checkLedgerReady
     if (pollingIntervalId !== null) {
-      console.log(
-        '[confirm-transaction-base] avoiding multiple calls for ; id: ',
-        pollingIntervalId,
-      );
       return undefined;
     }
 
     let hardwareIsReady = true;
     try {
-      console.log(
-        `[confirm-transaction-base] about to call checkLedgerReady for ${fromAddress}`,
-      );
       hardwareIsReady = await checkLedgerReady(fromAddress);
-      console.log(`[confirm-transaction-base] RETURNED! ${hardwareIsReady}`);
     } catch (e) {
-      console.error(
-        '[confirm-transaction-base] ERROR checking ledger ready!',
-        e,
-      );
+      // Don't let this check blow up the process
     }
 
     this.setState({ hardwareIsReady, pollingIntervalId: null });
     return undefined;
   }
 
   UNSAFE_componentWillMount() {
-    console.log('UNSAFE_componentWillMount!');
-
     const { showLedgerSteps } = this.props;
 
     if (!showLedgerSteps) {
@@ -712,7 +694,6 @@ export default class ConfirmTransactionBase extends Component {
           <HardwareConnectivityMessage
             connected={hardwareIsReady}
             onClick={(e) => {
-              console.log('Opening the modal!');
               e?.preventDefault?.();
               this.setState({ showingHardwareConnectionContents: true });
             }}

ui/pages/confirm-transaction-base/hardware-connectivity/hardware-connectivity-message.js

@@ -20,9 +20,12 @@ export default function HardwareConnectivityMessage({
           ) : (
             <>
               {t('hardwareWalletConnectivityNotConnected', ['Ledger'])}{' '}
-              <a href="javascript:;" onClick={onClick}>
+              <button
+                className="hardware-connectivity-message__button"
+                onClick={onClick}
+              >
                 {t('hardwareWalletConnectivityNotConnectedConversion')}
-              </a>
+              </button>
             </>
           )
         }

ui/pages/confirm-transaction-base/hardware-connectivity/index.scss

@@ -18,3 +18,9 @@
     font-size: 0.75rem;
   }
 }
+
+.hardware-connectivity-message__button {
+  font-size: inherit;
+  background: unset;
+  padding: 0;
+}