Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message replies are sometimes mixed up #72

Open
Gudahtt opened this issue Apr 21, 2021 · 0 comments
Open

Message replies are sometimes mixed up #72

Gudahtt opened this issue Apr 21, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@Gudahtt
Copy link
Member

Gudahtt commented Apr 21, 2021

When we send a message to the injected iframe, we assume the first reply we see is the response to that message. That might not be the case if we call the same method multiple times in quick succession.

To ensure we don't get our replies mixed up, we should attach a unique identifier to each message and look for it in the reply.

@Gudahtt Gudahtt added the bug Something isn't working label Apr 21, 2021
@Gudahtt Gudahtt changed the title Ensure message replies don't get mixed up Message replies are sometimes mixed up Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant