Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a non-controller with empty state, TokenDetectionController should not inherit from BaseController #4435

Open
Tracked by #4432
MajorLift opened this issue Jun 18, 2024 · 0 comments

Comments

@MajorLift
Copy link
Contributor

MajorLift commented Jun 18, 2024

Requirements

  • Should not inherit from BaseControllerV1 or BaseController.
  • Should not use the Controller suffix in its name.
  • Types for ControllerState, ControllerGetStateAction, ControllerStateChangeEvent should not be defined or exported.
  • Should accept messenger as a constructor option.
  • messenger should be defined with allowlists that enable the class to make all communications with other controller classes that were previously supported.
  • Should not accept any class method callbacks as constructor options. Messenger actions/events should be used to communicate instead.
  • In some cases, methods that implement API interactions should be extracted into a dedicated service class.
@MajorLift MajorLift changed the title TokenDetectionController As a non-controller with empty state, TokenDetectionController should not inherit from BaseController Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant