From 1f22147cd14462e11b82cd367cbf7b786358d6e5 Mon Sep 17 00:00:00 2001
From: kunish <kunish.butt@gmail.com>
Date: Thu, 28 Sep 2023 16:53:53 +0800
Subject: [PATCH] fix(rule): rule pages filter logic is not stable, fixes #313

---
 src/pages/Rules.tsx | 24 ++++++++++++++++++------
 1 file changed, 18 insertions(+), 6 deletions(-)

diff --git a/src/pages/Rules.tsx b/src/pages/Rules.tsx
index 171ac9a2..6a3114ee 100644
--- a/src/pages/Rules.tsx
+++ b/src/pages/Rules.tsx
@@ -79,25 +79,36 @@ export default () => {
 
   let scrollElementRef: HTMLDivElement | undefined
 
+  const getRuleItemKey = ({ type, payload, proxy }: Rule) =>
+    `${type}-${payload}-${proxy}`
+
   const ruleVirtualizer = createVirtualizer({
     get count() {
       return filteredRules().length
     },
-    getItemKey: (index) => filteredRules()[index].payload,
+    getItemKey: (index) => getRuleItemKey(filteredRules()[index]),
     getScrollElement: () => scrollElementRef!,
-    estimateSize: () => 74,
+    estimateSize: () => 82,
     overscan: 5,
   })
 
   const ruleVirtualizerItems = ruleVirtualizer.getVirtualItems()
 
+  const getRuleProviderItemKey = ({
+    type,
+    name,
+    vehicleType,
+    behavior,
+  }: RuleProvider) => `${type}-${name}-${vehicleType}-${behavior}`
+
   const ruleProviderVirtualizer = createVirtualizer({
     get count() {
       return filteredRuleProviders().length
     },
-    getItemKey: (index) => filteredRuleProviders()[index].name,
+    getItemKey: (index) =>
+      getRuleProviderItemKey(filteredRuleProviders()[index]),
     getScrollElement: () => scrollElementRef!,
-    estimateSize: () => 74,
+    estimateSize: () => 82,
     overscan: 5,
   })
 
@@ -157,7 +168,7 @@ export default () => {
           >
             {ruleVirtualizerItems.map((virtualizerItem) => {
               const rule = filteredRules().find(
-                (rule) => rule.payload === virtualizerItem.key,
+                (rule) => getRuleItemKey(rule) === virtualizerItem.key,
               )!
 
               return (
@@ -197,7 +208,8 @@ export default () => {
           >
             {ruleProviderVirtualizerItems.map((virtualizerItem) => {
               const ruleProvider = ruleProviders().find(
-                (ruleProvider) => ruleProvider.name === virtualizerItem.key,
+                (ruleProvider) =>
+                  getRuleProviderItemKey(ruleProvider) === virtualizerItem.key,
               )!
 
               return (