Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guess filetype for files without extensions #18

Open
nanxstats opened this issue Aug 9, 2021 · 4 comments
Open

Guess filetype for files without extensions #18

nanxstats opened this issue Aug 9, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@nanxstats
Copy link
Collaborator

nanxstats commented Aug 9, 2021

When evaluating file specifications to create file collections, we should follow this:

  • If a file has a known extensions, mark it as text or binary based on the dictionary (implemented)
  • Include files that do not have a file extension, and files with extensions not covered by the dictionary
  • Document this flow in the specification section
@nanxstats nanxstats added the enhancement New feature or request label Aug 9, 2021
@nanxstats nanxstats self-assigned this Aug 9, 2021
@nanxstats
Copy link
Collaborator Author

From Yilong: or, simply classify files with unknown extensions as binary files.

@nanxstats
Copy link
Collaborator Author

nanxstats commented Mar 21, 2022

The goal is to separate file capture rules and file type tagging rules and make them more universal, instead of limiting both flows with only known file extensions.

Action items:

  • For file capturing: Make some file specifications not file extension-based by removing the file name pattern constraint, e.g., file_inst(), to make them capture arbitrary files.
  • For file type tagging: Revise the tagging strategy by using the file extension dictionary + marking everything else binary.
  • Add file specification functions for more directories observed here: demo/, exec/, po/, build/.

@elong0527
Copy link
Collaborator

Shall we close the issue?

@nanxstats
Copy link
Collaborator Author

Not yet. This hasn't been shipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants