Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with gsDesign when integering sample size #487

Open
LittleBeannie opened this issue Nov 7, 2024 · 0 comments · May be fixed by #488
Open

Sync with gsDesign when integering sample size #487

LittleBeannie opened this issue Nov 7, 2024 · 0 comments · May be fixed by #488
Assignees

Comments

@LittleBeannie
Copy link
Collaborator

LittleBeannie commented Nov 7, 2024

gsDesign's sample size is rounded up to the nearest multiple of ratio + 1 when roundUpFinal = TRUE is specified. If roundUpFinal = FALSE, the final sample size is rounded to the nearest multiple of ratio + 1. (see https://github.com/keaven/gsDesign/blob/master/R/toInteger.R#L88-#L92)

In the current version of gsDesign2, the FA sample size is always round up to the nearest multiple of ratio +1. Besides, we will check if the ratio is integer or not, similar to gsDesign https://github.com/keaven/gsDesign/blob/master/R/toInteger.R#L52.

Additionally, the ratio argument will be added with a default value of 0, for consistency with gsDesign, see https://github.com/keaven/gsDesign/blob/master/R/toInteger.R#L85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant