Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Objective model and System #18

Merged
merged 2 commits into from
May 21, 2019
Merged

Objective model and System #18

merged 2 commits into from
May 21, 2019

Conversation

serpi90
Copy link
Contributor

@serpi90 serpi90 commented May 21, 2019

resolves #3
resolves #4

Complete and refactor model for:

  • Objective
  • Key Result
  • Period

Moves uuid to a new Trait: IdentifiableObject

Implements/Adds CRUD protocol to:

  • ObjectiveManagementSystem
  • KeyResultManagementSystem

@serpi90
Add Objective, ObjectiveManagementSystem and tests, complete KeyResul…
55d49d5 
…tManagementSystem model

- Move #uuid to an IdentifiableObject Trait
- Complete implementation of KeyResultManagementSystem to have minimal protocol required for a CRUD API
- Implement ObjectiveManagementSystem with protocol for a CRUD API
- Tests
@serpi90
Copy link
Contributor Author

serpi90 commented May 21, 2019

Seriously Considering implementing a CRUDSystem Trait to avoid code duplication, it should have:

  • #startManaging:
  • #stopManaging
  • #contents
  • #update:with:
  • #contentsFilteredBy:
  • #findOneSatisfying:ifNone:

@serpi90 serpi90 requested review from jvanecek and gcotelli and removed request for jvanecek May 21, 2019 04:12
@jvanecek jvanecek merged commit 491173c into release-candidate May 21, 2019
@jvanecek jvanecek deleted the 4-Modelo-para-objetivo branch May 21, 2019 23:26
@jvanecek jvanecek mentioned this pull request May 22, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvanecek jvanecek jvanecek approved these changes

@gcotelli gcotelli Awaiting requested review from gcotelli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sistema de Objetivos Modelo para objetivo
2 participants
@serpi90 @jvanecek