Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seems not to work with iPhone X models #326

Open
ddownn opened this issue Jan 20, 2019 · 2 comments
Open

Seems not to work with iPhone X models #326

ddownn opened this issue Jan 20, 2019 · 2 comments

Comments

@ddownn
Copy link

ddownn commented Jan 20, 2019

I've had some trouble getting this to work consistently with Predictive Text on vs. off, and on all iPhone X models there is a significant gap between the top of the keyboard and the bottom of the constrained element, while the older iPhone models appear correctly.

@vahids
Copy link

vahids commented Mar 5, 2019

temp fix:
I used AssistantKit pod and edit this line 53 of KeyboardLayoutConstraint.swift to:
keyboardVisibleHeight = frame.size.height - (Device.isNotched ? 34 : 0)

@abilenko
Copy link

abilenko commented Jun 6, 2019

Thank you for reply @vahids.

This is my solution:
Edit this line 53 of KeyboardLoyoutConstraint.swift to:

let bottomSafeAreaInset = UIApplication.shared.keyWindow?.safeAreaInsets.bottom ?? 0 keyboardVisibleHeight = frame.size.height - bottomSafeAreaInset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants