Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generalize stream tags #107

Open
xDashh opened this issue Oct 15, 2018 · 4 comments
Open

generalize stream tags #107

xDashh opened this issue Oct 15, 2018 · 4 comments

Comments

@xDashh
Copy link
Member

xDashh commented Oct 15, 2018

At the moment there is something like a stream table that contains boolean flags for some pre-defined tags (nsfw,afk,...) that streams can receive. Instead, think about setting tags dynamically, and letting the front-end decide what to do with any given tag. In the future that might allow people to tag their own streams and letting people filter via that.

Another idea is introducing special tags like news for streams that could be displayed in some special way as always-online regardless of viewership for well-known always-online news coverage streams.

Another idea: admin ability to mark custom m3u8/advanced embeds "saved" so you do not have to click the warning away. General version: whitelist whole domains or similar.

@kenany
Copy link
Member

kenany commented Oct 20, 2018

On the database side of things, I don't think our DB supports arrays, so I guess this would need to be, say, a comma-delimited string of tags.

@xDashh
Copy link
Member Author

xDashh commented Oct 20, 2018

I think in a case like this you usually define some tag-table that has id-name pairs, and then associate streams with tag-ids so new tags don't require db modification, just insertion... But JSON(-like?) storage seems doable too, especially for user-settings (related issue #98 ). I think at least sqlite has a JSON type now.

@slugalisk
Copy link
Member

The only people using the stream path feature are twitch broadcasters trying to promote their stream. We have no practical way to verify ownership for /service/channel streams. Who is allowed to modify which streams?

@xDashh
Copy link
Member Author

xDashh commented Oct 20, 2018

People don't use the stream_path because it has no benefit I'd say. If we want to push this, there'd have to be some incentive. Being able to put tags on your stream (once they are useful in some way) could be one of them.

To answer the question: for the kinds of streams you mention, only admins most likely...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants