From 3a6b49b78b82979a1641753862b59a747fbde7da Mon Sep 17 00:00:00 2001 From: Sebastian Smiley Date: Thu, 13 Jul 2023 14:53:42 -0400 Subject: [PATCH 1/3] Move non-secret environment variables to test.yml --- .github/workflows/test.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 7be1e31..29dd28d 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -17,11 +17,11 @@ jobs: matrix: python-version: ["3.8", "3.9", "3.10", "3.11"] env: - AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }} + AWS_ACCESS_KEY_ID: AKIAZPOBIXUJJ434XT5T AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }} - TAP_UNIVERSAL_FILE_FILEPATH: ${{ vars.TAP_UNIVERSAL_FILE_FILEPATH }} - TAP_UNIVERSAL_FILE_FILE_REGEX: ${{ vars.TAP_UNIVERSAL_FILE_FILE_REGEX }} - TAP_UNIVERSAL_FILE_PROTOCOL: ${{ vars.TAP_UNIVERSAL_FILE_PROTOCOL }} + TAP_UNIVERSAL_FILE_FILEPATH: derek-tap-filetesting/2023 + TAP_UNIVERSAL_FILE_FILE_REGEX: .*\.csv$ + TAP_UNIVERSAL_FILE_PROTOCOL: s3 steps: - uses: actions/checkout@v3 - name: Set up Python ${{ matrix.python-version }} From b7d7452e38dd09e803b79fa08a8047630c608ad9 Mon Sep 17 00:00:00 2001 From: Sebastian Smiley Date: Thu, 13 Jul 2023 15:49:25 -0400 Subject: [PATCH 2/3] Correct s3 bucket and add file_regex --- tests/test_core.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/test_core.py b/tests/test_core.py index ec6080c..fdd2375 100644 --- a/tests/test_core.py +++ b/tests/test_core.py @@ -132,7 +132,11 @@ def test_avro_execution(): def test_s3_execution(): - s3_config = {"protocol": "s3", "filepath": "tap-file-taptesting/grocery"} + s3_config = { + "protocol": "s3", + "filepath": "derek-tap-filetesting/2023", + "file_regex": "airtravel\\.csv$", + } execute_tap(s3_config) From ad05b33b045cc110d3e503459d590cc79b72b072 Mon Sep 17 00:00:00 2001 From: Sebastian Smiley Date: Thu, 13 Jul 2023 15:53:16 -0400 Subject: [PATCH 3/3] Update file_regex in test.yml --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 29dd28d..e580240 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -20,7 +20,7 @@ jobs: AWS_ACCESS_KEY_ID: AKIAZPOBIXUJJ434XT5T AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }} TAP_UNIVERSAL_FILE_FILEPATH: derek-tap-filetesting/2023 - TAP_UNIVERSAL_FILE_FILE_REGEX: .*\.csv$ + TAP_UNIVERSAL_FILE_FILE_REGEX: ^airtravel\.csv$ TAP_UNIVERSAL_FILE_PROTOCOL: s3 steps: - uses: actions/checkout@v3