Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn if table in tables config is not found #24

Open
pnadolny13 opened this issue May 26, 2023 · 1 comment
Open

Warn if table in tables config is not found #24

pnadolny13 opened this issue May 26, 2023 · 1 comment

Comments

@pnadolny13
Copy link
Contributor

pnadolny13 commented May 26, 2023 •
edited
Loading

From my testing today it looks like we attempt to find a match but if not we silently complete with no records synced. As a user it would be nice to get a warning, or even an error potentially, if my configured table wasnt found. If I was running this is production and the table disappeared the job would continue to succeed as if the data was synced, which could lead to some unexpected results and might make me lean in favor of throwing an error.
@peter-malcolm-bw
Copy link

peter-malcolm-bw commented Jul 11, 2024 •
edited
Loading

We just got burned by this issue too. This would be a great addition to the tap 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
MeltanoLabs Overview
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pnadolny13 @peter-malcolm-bw