-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schema for issues.fields.customfield_* is not generalized #58
Comments
Hi @akoebbe-uu , I think we can create some sort of schema generator for this tap but don't know if that's super handy. @edgarrmondragon I know that tap-salesforce does something like this. |
@prakharcode I think you're right. I'm pretty sure every instance of Jira will have different field types for custom fields. Meaning The |
Here's a specific case where the extract fails because of the custom field mismatch. In the tap code, Lines 1680 to 1693 in 80638d8
But in an instance I'm trying to pull from the Jira API defines the schema as: {
"id": "customfield_10005",
"key": "customfield_10005",
"name": "Business Value",
"untranslatedName": "Business Value",
"custom": true,
"orderable": true,
"navigable": true,
"searchable": true,
"clauseNames": [
"Business Value",
"Business Value[Number]",
"cf[10005]"
],
"schema": {
"type": "number",
"custom": "com.atlassian.jira.plugin.system.customfieldtypes:float",
"customId": 10005
}
} |
The schema defined in the IssueStream of this tap will not work for everyone because Jira uses something akin to EAV for custom fields. One project's
issues.fields.customfield_10004
may be a string (how it's currently defined), but mine is a number. Therefore, the validation will always fail. Either the schema needs to allow for any datatype inissues.fields.customfield_*
, or the tap needs to inspect Jira's field schema API to dynamically set the schema correctly for the instance it's extracting.Field information API: /rest/api/3/field/ (Docs)
The text was updated successfully, but these errors were encountered: