Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests #43

Open
pnadolny13 opened this issue Oct 18, 2021 · 1 comment
Open

Add tests #43

pnadolny13 opened this issue Oct 18, 2021 · 1 comment

Comments

@pnadolny13
Copy link
Collaborator

In GitLab by @tomelliff on Oct 21, 2020, 13:09

I've noticed that very few taps and targets seem to have tests but I felt particularly uncomfortable making an untested change despite the fact it was very small. https://github.com/transferwise/pipelinewise-tap-postgres/tree/master/tests shows a high quality tap that does have tests and it doesn't look too painful.

Would you accept a small MR to add the start of some tests for now and then we can expand them as we go and insist on tests for any new functionality?

@pnadolny13
Copy link
Collaborator Author

In GitLab by @DouweM on Oct 27, 2020, 14:42

Would you accept a small MR to add the start of some tests for now and then we can expand them as we go and insist on tests for any new functionality?

@tomelliff Definitely, please do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant