You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've noticed that very few taps and targets seem to have tests but I felt particularly uncomfortable making an untested change despite the fact it was very small. https://github.com/transferwise/pipelinewise-tap-postgres/tree/master/tests shows a high quality tap that does have tests and it doesn't look too painful.
Would you accept a small MR to add the start of some tests for now and then we can expand them as we go and insist on tests for any new functionality?
The text was updated successfully, but these errors were encountered:
In GitLab by @tomelliff on Oct 21, 2020, 13:09
I've noticed that very few taps and targets seem to have tests but I felt particularly uncomfortable making an untested change despite the fact it was very small. https://github.com/transferwise/pipelinewise-tap-postgres/tree/master/tests shows a high quality tap that does have tests and it doesn't look too painful.
Would you accept a small MR to add the start of some tests for now and then we can expand them as we go and insist on tests for any new functionality?
The text was updated successfully, but these errors were encountered: