Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard Tests Framework Rollout #40

Open
8 tasks
kgpayne opened this issue Jan 26, 2023 · 3 comments
Open
8 tasks

Standard Tests Framework Rollout #40

kgpayne opened this issue Jan 26, 2023 · 3 comments
Assignees

Comments

@kgpayne
Copy link

kgpayne commented Jan 26, 2023

In anticipation of sdk##1171 merging, this issue is to track the rollout of the new tests to commonly used Taps and Targets in MeltanoLabs:

Key:

  • 🚫 Blocked
  • ⚠️ In Progress
  • ✅ Done

Taps:

Targets:

@aaronsteers
Copy link

@kgpayne - Thanks very much for pre-testing here.

As I noted in the main SDK PR, one thing I wanted to check was to confirm that the old and new test methods both still work. I added back the legacy test with a test_sdk_legacy.py test file name on PR. Looking at the tap-github and tap-stackexchange, it looks like the old method is still in place (at least as of now). Safe to assume we expect legacy tests to keep working at the same time as we are lighting up the new test methods?

@edgarrmondragon
Copy link
Member

Safe to assume we expect legacy tests to keep working at the same time as we are lighting up the new test methods?

Might be worth setting a deprecation timeline for the legacy tests. I've ported a docs reorganization from meltano/sdk#1294 into meltano/sdk#1353 that includes a deprecation page: https://meltano-sdk--1353.org.readthedocs.build/en/1353/development/deprecation.html

@aaronsteers
Copy link

aaronsteers commented Jan 26, 2023

@edgarrmondragon - Good point. I think in v1.0 we should remove them. I'll log I've logged this as an issue for follow-up as part of the 1.0 milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants