Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meltano supported tap-postgres #35

Open
4 of 8 tasks
pnadolny13 opened this issue Jan 24, 2023 · 4 comments
Open
4 of 8 tasks

Meltano supported tap-postgres #35

pnadolny13 opened this issue Jan 24, 2023 · 4 comments

Comments

@pnadolny13
Copy link
Contributor

pnadolny13 commented Jan 24, 2023

Development Scope:

Out of Scope Features Mentioned:

@pnadolny13
Copy link
Contributor Author

pnadolny13 commented Jan 24, 2023

@tayloramurphy I created this to define the scope of development for these new plugins, track status, and decide when its ready to recommend. Can you help fill in the description with the features (specific to this source) we expect the initial release to support? It will help us and users understand what done is and when we're there.

cc @visch @aaronsteers

@visch
Copy link
Member

visch commented Feb 1, 2023

This one needs some love that's for sure

These 4 are pretty straight forward and <a few hours of work.

  1. tests pass in CI - feat: CI tests, linting, formatting, typechecking, SDK version bump tap-postgres#26 Quinn has this one pretty much done
  2. branch protection - Branch Protection Added tap-postgres#27
  3. cookiecutter TODOs completed and removed - Remove TODOs left over from cookiecutter tap-postgres#28
  4. clean README- Clean Readme tap-postgres#29
  5. CD together, with deploys to PyPi - Auto deploy to PyPi on release creation see target-postgres tap-postgres#31

Feature coverage missing things. I can't say what should/shouldn't be there before we make the default switch but here's generally the "Important" missing features. The biggest thing transferwise has over this tap is that they have had their tap around longer so it's just seen more stuff in the wild

  1. Log based pulls - Feat: add LOG_BASED replication option tap-postgres#3
  2. SSL / Username / Host broken out configurations - Break out host/port/username configurations tap-postgres#30

@aaronsteers
Copy link

aaronsteers commented Feb 2, 2023

@visch - Thanks for logging these. We have an emerging standard practice for CD deployments to PyPi, so I think it's safe to leave that out or do manually a few times for now.

I do agree this one is important since it may front-load some breaking changes:

This can come along a little later when higher priorities are all addressed:

Agreed SSL is a nice-to-have and important but perhaps not yet "urgent". After we build into tap-postgres (and/or target-postgres), the long-term plan is to work this into the SDK as well:

@pnadolny13
Copy link
Contributor Author

@aaronsteers @visch this is great! I updated the issue checklist with what I think is the consensus in/out of scope items. Definitely feel free to change them if more stuff comes up thats blocking us recommending this variant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants