Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slurm integration python2/3 confusion #35

Open
jabl opened this issue Oct 28, 2022 · 1 comment
Open

Slurm integration python2/3 confusion #35

jabl opened this issue Oct 28, 2022 · 1 comment

Comments

@jabl
Copy link

jabl commented Oct 28, 2022

The slurm integration scripts in plugins/SLURM-Integration are launched via the ufm-{prolog,epilog}.sh scripts which launch them by running python3. However the python scripts themselves contain the shebang path /usr/bin/python, which depending on the system setup, can still point to the old python 2.x interpreter. Can you please fix so that python 2.x is not used by accident e.g. when testing?

ufm_sdk_3.0/plugins/SLURM-Integration$ git grep usr/bin/python
ufm_slurm_base.py:#!/usr/bin/python
ufm_slurm_epilog.py:#!/usr/bin/python
ufm_slurm_prolog.py:#!/usr/bin/python
ufm_slurm_utils.py:#!/usr/bin/python
@flx42
Copy link
Contributor

flx42 commented Feb 20, 2023

I agree with the assessment of @jabl, can we fix this please? In addition, python files that are not meant to be executed directly should probably not be executable (like ufm_slurm_utils.py), nor have a shebang at all (ufm_slurm_base.py and ufm_slurm_utils.py).

@anasbadaha @mike-dubman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants