Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-feature-discovery chart parity with gpu-operator #1212

Open
wcrum opened this issue Dec 10, 2024 · 3 comments
Open

node-feature-discovery chart parity with gpu-operator #1212

wcrum opened this issue Dec 10, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@wcrum
Copy link

wcrum commented Dec 10, 2024

What happened:

Referencing and using this network operator alongside the nvidia/gpu-operator and deploying node-feature-discovery should there be parity between the versions of node-feature-discovery?

Latest GPU Operator uses v16.6 and latest network-operator uses v15.6.

What you expected to happen:
node-feature-discovery to be the same across both GPU / Network operator.

How to reproduce it (as minimally and precisely as possible):

https://github.com/NVIDIA/gpu-operator/blob/9afd674d510f2b4e431d9455130d3a8d030e614f/deployments/gpu-operator/charts/node-feature-discovery/Chart.yaml#L2

@wcrum wcrum added the bug Something isn't working label Dec 10, 2024
@wcrum
Copy link
Author

wcrum commented Dec 10, 2024

Happy to submit PR to match / update node-feature-discovery if this should be on version v16.6 (latest NDF).

@noama-nv
Copy link

One instance of NFD should be running at a time in a kubernetes cluster. NFD should be installed as standalone / with Network Operator / with GPU Operator

you should enable NodeFeatureRule by network operator
see
https://mellanox.github.io/network-operator-docs/customizations/helm.html?highlight=deployNodeFeatureRules

@wcrum
Copy link
Author

wcrum commented Dec 25, 2024

I understand, GPU Operator and the network operator have different versions of NFD. Is there a bump required for network operator which enables and deploys NFD?

@wcrum wcrum mentioned this issue Jan 17, 2025
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants