New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification Administration - Upgrade UI #79

Closed

srenault-meeds opened this issue Aug 31, 2023 · 11 comments · Fixed by Meeds-io/social#2820, Meeds-io/commons#507, Meeds-io/gamification#1198, Meeds-io/kudos#348 or Meeds-io/perk-store#267

Labels

Go - fonc Go - tech

Milestone

Collaborator

srenault-meeds commented Aug 31, 2023 •

edited

Loading

Rationale

Notifications Administration UI is not consistent with other platform UI.
Indeed, the following UI is not accurate with what is expected to see:

In addition to the fact that UX is not the best here:

Sender informations are "hidden" as it is at the bottom of the app
To disable / enable a notification channel, it is needed to do it notification per notification

1. Functional Requirements

The UI will be updated to make sure it is consistent with other UI in the platform.

View of future notifications admin page:

With ability for admin to enable/disable any notification by channel type. When disabled, users won't be able to enable it.
With ability for admin to set the notification sender settings with a proper drawer:

to set the sender
to edit the sender mail without changing the domain name

2. Technical Requirements

Upgradability

The old portlet NotificationsAdminJuzuPortlet has to be replaced in social by a portlet with name NotificationAdministration.

Other Non Functional Requirements

The new portlet has to be made using Vue & REST endpoints.

4. Software Architecture

Migration strategy

The definition of UI & REST endpoint has to be moved to social. Knowing that the old portlet will be replaced, the importMode of administrators portal has to be of type merge or overwrite.

The text was updated successfully, but these errors were encountered:

srenault-meeds added this to MIP Board

github-project-automation bot moved this to Open in MIP Board

srenault-meeds changed the title ~~DRAFT - Notification - Upgrade UI~~ Notification Administration - Upgrade UI

srenault-meeds moved this from Open to Submitted in MIP Board

Member

boubaker commented Sep 4, 2023

ready for tech review @rdenarie

boubaker added the To check label

margondicco commented Sep 4, 2023

Hello

my feedback : it isn't default notification for user and per type because the end user could not change these settings.

If the administrator define the choice false for the email notification for the type someone request to join a space, the end user could not change it.

BUT

it's a real big requirement.... So if you want to change the mandatory to default, i will be very happy !

boubaker added a commit to Meeds-io/commons that referenced this issue


          feat: Move Notification REST and UI to Social - MEED-2445 - Meeds-io/…

f2e20c0

…MIPs#79

boubaker added a commit to Meeds-io/commons that referenced this issue


          feat: Move Notification REST and UI to Social - MEED-2445 - Meeds-io/…

c0e5260

…MIPs#79 (#502)

This change will move Notification UI from Juzu Portlet to Vue Portlet.
At the same time, this will move REST endpoint into Social-notification
component.

boubaker added a commit to Meeds-io/social that referenced this issue


          feat: Move Notification UI from Commons - MEED-2445 - Meeds-io/MIPs#79

114b10d

This change will move Notification Administration UI from Commons into Social, same as the REST API endpoint. The new portlet is defined using Vue instead of Juzu.

boubaker added a commit to Meeds-io/social that referenced this issue


          feat: Move Notification UI from Commons - MEED-2445 - Meeds-io/MIPs#79 (

c9cd41c

#2791)

This change will move Notification Administration UI from Commons into
Social, same as the REST API endpoint. The new portlet is defined using
Vue instead of Juzu.

Collaborator Author

srenault-meeds commented Sep 4, 2023

Hello

my feedback : it isn't default notification for user and per type because the end user could not change these settings.

If the administrator define the choice false for the email notification for the type someone request to join a space, the end user could not change it.

BUT

it's a real big requirement.... So if you want to change the mandatory to default, i will be very happy !

Thanks for highlighting it! We have updated this requirement and we will stick to the current behaviour: the admin enables or disables notifications for user.
Pre setting notifications will be studied afterwards in another MIP

exo-swf pushed a commit to Meeds-io/social that referenced this issue


          feat: Move Notification UI from Commons - MEED-2445 - Meeds-io/MIPs#79 (

9bd059f

#2791)

This change will move Notification Administration UI from Commons into
Social, same as the REST API endpoint. The new portlet is defined using
Vue instead of Juzu.

boubaker added a commit to Meeds-io/commons that referenced this issue


          feat: Move Notification REST and UI to Social - MEED-2445 - Meeds-io/…

cc194f3

…MIPs#79 (#502)

This change will move Notification UI from Juzu Portlet to Vue Portlet.
At the same time, this will move REST endpoint into Social-notification
component.

boubaker added a commit to Meeds-io/social that referenced this issue


          feat: Move Notification UI from Commons - MEED-2445 - Meeds-io/MIPs#79 (

a62843e

#2791)

This change will move Notification Administration UI from Commons into
Social, same as the REST API endpoint. The new portlet is defined using
Vue instead of Juzu.

boubaker added a commit to Meeds-io/commons that referenced this issue


          feat: Move Notification REST and UI to Social - MEED-2445 - Meeds-io/…

de6da88

…MIPs#79 (#502)

This change will move Notification UI from Juzu Portlet to Vue Portlet.
At the same time, this will move REST endpoint into Social-notification
component.

boubaker added a commit to Meeds-io/social that referenced this issue


          feat: Move Notification UI from Commons - MEED-2445 - Meeds-io/MIPs#79 (

a7b39b9

#2791)

This change will move Notification Administration UI from Commons into
Social, same as the REST API endpoint. The new portlet is defined using
Vue instead of Juzu.

boubaker added a commit to Meeds-io/gamification that referenced this issue


          feat: Delete usage of Juzu and adapt Notification Settings - MEED-2445 …

2085a19

…- Meeds-io/MIPs#79

This change updates Badges Portlet to not use Juzu anymore which has been deleted from Notifications Admin, the last portlet using Juzu. In addition, this change will adapt some Unit Tests to new behavior of Notification Settings that ensures that users are enabled before sending notification.

boubaker added a commit to Meeds-io/social that referenced this issue


          feat: Move Notification UI from Commons - MEED-2445 - Meeds-io/MIPs#79 (

ae11d68

#2791)

This change will move Notification Administration UI from Commons into
Social, same as the REST API endpoint. The new portlet is defined using
Vue instead of Juzu.

boubaker added a commit to Meeds-io/social that referenced this issue


          feat: Move Notification UI from Commons - MEED-2445 - Meeds-io/MIPs#79 (

668b76e

#2791)

This change will move Notification Administration UI from Commons into
Social, same as the REST API endpoint. The new portlet is defined using
Vue instead of Juzu.

boubaker added the Dev in progress label

margondicco commented Sep 5, 2023

Thank you. Go Fonc :-)

boubaker added the Go - fonc label

exo-swf pushed a commit to Meeds-io/gamification that referenced this issue


          feat: Delete usage of Juzu and adapt Notification Settings - MEED-2445 …

…- Meeds-io/MIPs#79

This change updates Badges Portlet to not use Juzu anymore which has been deleted from Notifications Admin, the last portlet using Juzu. In addition, this change will adapt some Unit Tests to new behavior of Notification Settings that ensures that users are enabled before sending notification.

boubaker mentioned this issue

Remove Juzu dependency #82

Closed

exo-swf pushed a commit to Meeds-io/social that referenced this issue


          feat: Move Notification UI from Commons - MEED-2445 - Meeds-io/MIPs#79 (

a7c4dcc

#2791)

This change will move Notification Administration UI from Commons into
Social, same as the REST API endpoint. The new portlet is defined using
Vue instead of Juzu.

Member

boubaker commented Sep 8, 2023

ready for tech review @rdenarie

rdenarie added the Go - tech label

Member

rdenarie commented Sep 8, 2023

Go tech added

boubaker added a commit to Meeds-io/meeds-qa-ui that referenced this issue


          feat: Add Manage Notifications Test Cases - MEED-2445 - MEED-2446 - M…

b2f1120

…eeds-io/MIPs#79

boubaker added a commit to Meeds-io/task that referenced this issue


          Merge Notification Adminitration UI Meeds-io/MIPs#79 (#236)

8f8e4f7

boubaker added a commit to Meeds-io/meeds-qa-ui that referenced this issue


          feat: Add Manage Notifications Test Cases - MEED-2445 - MEED-2446 - M…

381d717

…eeds-io/MIPs#79 (#179)

This Test will implement the following Test cases:
- When disabling a channel from admin, then it is no more proposed to
users
- Notification sender email form validation

boubaker added a commit to Meeds-io/kudos that referenced this issue


          Merge Notification Adminitration UI Meeds-io/MIPs#79 (#507)

28039e2

boubaker added a commit to Meeds-io/social that referenced this issue


          Merge Notification Adminitration UI Meeds-io/MIPs#79 (#2820)

9b422fb

Member

boubaker commented Sep 11, 2023

Thanks. PRs merged to develop.

exo-swf pushed a commit to Meeds-io/commons that referenced this issue


          feat: Move Notification REST and UI to Social - MEED-2445 - Meeds-io/…

8a56abf

…MIPs#79 (#505)

This change will move Notification UI from Juzu Portlet to Vue Portlet.
At the same time, this will move REST endpoint into Social-notification
component.

exo-swf pushed a commit to Meeds-io/social that referenced this issue


          feat: Move Notification UI from Commons - MEED-2445 - Meeds-io/MIPs#79 (

c76bda0

#2815)

This change will move Notification Administration UI from Commons into
Social, same as the REST API endpoint. The new portlet is defined using
Vue instead of Juzu.

exo-swf pushed a commit to Meeds-io/gamification that referenced this issue


          feat: Delete usage of Juzu and adapt Notification Settings - MEED-2445 …

9884b14

…- Meeds-io/MIPs#79 (#1195)

This change updates Badges Portlet to not use Juzu anymore which has
been deleted from Notifications Admin, the last portlet using Juzu. In
addition, this change will adapt some Unit Tests to new behavior of
Notification Settings that ensures that users are enabled before sending
notification.

exo-swf pushed a commit to Meeds-io/kudos that referenced this issue


          feat: Add Notification Administration Label - MEED-2445 - Meeds-io/MI…

3ebaa06

…Ps#79 (#343)

Prior to this change, the notification label is displayed the same way in administration and user settings. This change will add a dedicated label when in administration scope.

exo-swf pushed a commit to Meeds-io/perk-store that referenced this issue


          feat: Add Notification Administration Label - MEED-2445 - Meeds-io/MI…

194dbb7

…Ps#79 (#266)

Prior to this change, the notification label is displayed the same way in administration and user settings. This change will add a dedicated label when in administration scope.

exo-swf pushed a commit to Meeds-io/wallet that referenced this issue


          feat: Add Notification Administration Label - MEED-2445 - Meeds-io/MI…

356a00c

…Ps#79 (#411)

Prior to this change, the notification label is displayed the same way
in administration and user settings. This change will add a dedicated
label when in administration scope.

exo-swf pushed a commit to Meeds-io/notes that referenced this issue


          feat: Add Notification Administration Label - MEED-2445 - Meeds-io/MI…

21a7766

…Ps#79 (#718)

Prior to this change, the notification label is displayed the same way
in administration and user settings. This change will add a dedicated
label when in administration scope.

exo-swf pushed a commit to Meeds-io/task that referenced this issue


          feat: Add Notification Administration Label - MEED-2445 - Meeds-io/MI…

86436a9

…Ps#79 (#234)

Prior to this change, the notification label is displayed the same way in administration and user settings. This change will add a dedicated label when in administration scope.

exo-swf pushed a commit to Meeds-io/meeds-qa-ui that referenced this issue


          feat: Add Manage Notifications Test Cases - MEED-2445 - MEED-2446 - M…

686ba74

…eeds-io/MIPs#79 (#179)

This Test will implement the following Test cases:
- When disabling a channel from admin, then it is no more proposed to
users
- Notification sender email form validation

rdenarie added a commit to exoplatform/multifactor-authentication that referenced this issue


          fix: move missing configuration file in mfa module - Meeds-io/MIPs#79 (…

99fd03d

…#38)

Before this fix, this mfa configuration was in social module.
This commit moves the configuration in the correct mfa module.

rdenarie added a commit to exoplatform/maven-exo-depmgt-pom that referenced this issue


          feat : Move deprecated juzu dependencies from meeds-io to exo - EXO-6…

ffdc4ca

…6190 - Meeds-io/MIPs#79

Juzu dependency is deprecated in meeds.
We still need it for chat, rh-management and customer space.
We move it in eXo side waiting the refactor of these components.

rdenarie added a commit to exoplatform/commons-exo that referenced this issue


          feat : Move deprecated juzu dependencies from meeds-io to exo - EXO-6…

215d5b2

…6190 - Meeds-io/MIPs#79

Juzu dependency is deprecated in meeds.
We still need it for chat, rh-management and customer space.
We move it in eXo side waiting the refactor of these components.

rdenarie added a commit to exoplatform/chat-application that referenced this issue


          feat : Move deprecated juzu dependencies from meeds-io to exo - EXO-6…

f753811

…6190 - Meeds-io/MIPs#79

Juzu dependency is deprecated in meeds.
We still need it for chat, rh-management and customer space.
We move it in eXo side waiting the refactor of these components.

exo-swf pushed a commit to exoplatform/chat-application that referenced this issue


          feat : Move deprecated juzu dependencies from meeds-io to exo - EXO-6…

147930f

…6190 - Meeds-io/MIPs#79

Juzu dependency is deprecated in meeds.
We still need it for chat, rh-management and customer space.
We move it in eXo side waiting the refactor of these components.

rdenarie added a commit to exoplatform/chat-application that referenced this issue


          feat : Move deprecated juzu dependencies from meeds-io to exo - EXO-6…

bbd6b04

…6190 - Meeds-io/MIPs#79

Juzu dependency is deprecated in meeds.
We still need it for chat, rh-management and customer space.
We move it in eXo side waiting the refactor of these components.

rdenarie added a commit to exoplatform/maven-exo-depmgt-pom that referenced this issue


          feat : Move deprecated juzu dependencies from meeds-io to exo - EXO-6…

d73bc30

…6190 - Meeds-io/MIPs#79

Juzu dependency is deprecated in meeds.
We still need it for chat, rh-management and customer space.
We move it in eXo side waiting the refactor of these components.

rdenarie added a commit to exoplatform/commons-exo that referenced this issue


          feat : Move deprecated juzu dependencies from meeds-io to exo - EXO-6…

97c28a6

…6190 - Meeds-io/MIPs#79

Juzu dependency is deprecated in meeds.
We still need it for chat, rh-management and customer space.
We move it in eXo side waiting the refactor of these components.

rdenarie added a commit to exoplatform/chat-application that referenced this issue


          feat : Move deprecated juzu dependencies from meeds-io to exo - EXO-6…

548aa62

…6190 - Meeds-io/MIPs#79

Juzu dependency is deprecated in meeds.
We still need it for chat, rh-management and customer space.
We move it in eXo side waiting the refactor of these components.

exo-swf pushed a commit to exoplatform/chat-application that referenced this issue


          feat : Move deprecated juzu dependencies from meeds-io to exo - EXO-6…

630e720

…6190 - Meeds-io/MIPs#79

Juzu dependency is deprecated in meeds.
We still need it for chat, rh-management and customer space.
We move it in eXo side waiting the refactor of these components.

rdenarie added a commit to exoplatform/commons-exo that referenced this issue


          feat : Move deprecated juzu dependencies from meeds-io to exo - EXO-6…

4b437f9

…6190 - Meeds-io/MIPs#79

Juzu dependency is deprecated in meeds.
We still need it for chat, rh-management and customer space.
We move it in eXo side waiting the refactor of these components.

rdenarie added a commit to exoplatform/maven-exo-depmgt-pom that referenced this issue


          feat : Move deprecated juzu dependencies from meeds-io to exo - EXO-6…

d65cdf1

…6190 - Meeds-io/MIPs#79 (#5)

Juzu dependency is deprecated in meeds.
We still need it for chat, rh-management and customer space.
We move it in eXo side waiting the refactor of these components.

rdenarie added a commit to exoplatform/commons-exo that referenced this issue


          feat : Move deprecated juzu dependencies from meeds-io to exo - EXO-6…

a745999

…6190 - Meeds-io/MIPs#79 (#5)

Juzu dependency is deprecated in meeds.
We still need it for chat, rh-management and customer space.
We move it in eXo side waiting the refactor of these components.

rdenarie added a commit to exoplatform/chat-application that referenced this issue


          feat : Move deprecated juzu dependencies from meeds-io to exo - EXO-6…

feff2d8

…6190 - Meeds-io/MIPs#79 (#661)

Juzu dependency is deprecated in meeds.
We still need it for chat, rh-management and customer space.
We move it in eXo side waiting the refactor of these components.

plamarque added this to the 1.5.0-M12 milestone

SaraBoutej pushed a commit to Meeds-io/social that referenced this issue


          feat: Move Notification UI from Commons - MEED-2445 - Meeds-io/MIPs#79 (

b850a5d

#2815)

This change will move Notification Administration UI from Commons into
Social, same as the REST API endpoint. The new portlet is defined using
Vue instead of Juzu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment