Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loss computation in pfedgraph_cosine.py #1

Open
tesiawang opened this issue Mar 11, 2024 · 0 comments
Open

Loss computation in pfedgraph_cosine.py #1

tesiawang opened this issue Mar 11, 2024 · 0 comments

Comments

@tesiawang
Copy link

Hi there, thanks a lot for the open-source codes!
Could you please tell me why 'args.lam' is positive in pfedgraph_cosine.py? This hyper-parameter is multiplied with loss2, which actually is the similarity instead of distance. Thus I personally think args.lam should be negative, just as what the equation (1) in the paper indicates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant