Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph Improvement Ideas #145

Closed
Gold872 opened this issue Feb 20, 2024 · 3 comments · Fixed by #184
Closed

Graph Improvement Ideas #145

Gold872 opened this issue Feb 20, 2024 · 3 comments · Fixed by #184
Labels
enhancement New feature or request

Comments

@Gold872
Copy link
Contributor

Gold872 commented Feb 20, 2024

I was playing around with the graph, and I had some ideas on new features to add to it. While it works great in its current state, it doesn't have some of the customizability and flexibility that is seen in other analysis tools such as the DS log viewer. I have a few ideas on new features/improvements:

  1. Ability to "select" a viewing range
    One useful feature would be able to easily select a viewing range by just dragging. It can be a bit annoying to zoom in and scroll through a massive log to see a variable over a 10 second window

I think dragging over this part should allow users to select a viewing range
image

  1. Ability to change line thickness/color
    I'm not sure whether or not this exists, but I couldn't find a way of changing the color of a specific variable. Whether or not it already exists, I think there could also be options for viewing it as a set of points instead of a line, different colors/line thicknesses, and maybe even a way of showing it as a bar graph instead of a line.

  2. Ability to show discrete field points only when the value changes/when a boolean value is true
    The primary use case of this is seeing when the robot is browned out/if we're connected. It was very useful in the DS log viewer and I would love to be able to use it in AdvantageScope.

@Gold872 Gold872 added the enhancement New feature or request label Feb 20, 2024
@cole-wilson
Copy link

I'd also like to add my support to this: I think being able to zoom on the line graph would be a very useful feature.

@jwbonner
Copy link
Member

@cole-wilson To be clear, you can already zoom in on the line graph by hovering the cursor over the graph and scrolling (up/down to zoom and left/right to pan). I believe the suggestion is to allow you to jump to a range directly by dragging on the timeline, which would also be a useful enhancement.

@cole-wilson
Copy link

Oh okay, thank you! I hadn't discovered that yet.

@jwbonner jwbonner linked a pull request Sep 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants