Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAT-7668: Bump to latest cqm-execution to correct Coverage calculation. #697

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

jkotanchik-SB
Copy link
Contributor

@jkotanchik-SB jkotanchik-SB commented Sep 13, 2024

MADiE PR

Jira Ticket: MAT-7668
Related PR: cqm-execution#269

Summary

Latest translator populates additional localIds across more ELM nodes. This update to cqm-execution filters out the Patient obj and Terminology data (both previously did not have localIds) from localId collection, thereby ensuring only related clauses are included in coverage calculation.

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included
  • No extemporaneous files are included (i.e Complied files or testing results)
  • This PR is into the correct branch.
  • All Documentation as needed for this PR is Complete (or noted in a TODO or other Ticket)
  • Any breaking changes or failing automation are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package)
  • All CDN/Web dependencies are hosted internally (i.e MADiE-Root Repo)

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads

@jkotanchik-SB jkotanchik-SB requested a review from a team as a code owner September 13, 2024 20:01
@jkotanchik-SB jkotanchik-SB self-assigned this Sep 13, 2024
adongare
adongare previously approved these changes Sep 13, 2024
Copy link

codacy-production bot commented Sep 13, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for eeeaad21
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (eeeaad2) Report Missing Report Missing Report Missing
Head commit (b483b82) 5296 4679 88.35%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#697) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@jkotanchik-SB jkotanchik-SB merged commit 28954e9 into develop Sep 13, 2024
10 checks passed
@jkotanchik-SB jkotanchik-SB deleted the feature/mat-7668-bump-cqm-execution branch September 13, 2024 20:14
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.92%. Comparing base (65fb075) to head (b483b82).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #697   +/-   ##
========================================
  Coverage    87.92%   87.92%           
========================================
  Files          188      188           
  Lines         5731     5731           
  Branches      1241     1241           
========================================
  Hits          5039     5039           
  Misses         636      636           
  Partials        56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants