Skip to content

Commit fa1188b

Browse files
authored
Merge pull request Catrobat#3702 from ndrnour/Catroid-636
CATROID-636: Migrate to AndroidX (targetSdkVersion 29)
2 parents b14a319 + 6b13111 commit fa1188b

11 files changed

+26
-9
lines changed

catroid/build.gradle

+2-2
Original file line numberDiff line numberDiff line change
@@ -132,12 +132,12 @@ jacocoAndroidUnitTestReport {
132132
}
133133

134134
android {
135-
compileSdkVersion 28
135+
compileSdkVersion 29
136136

137137
defaultConfig {
138138

139139
minSdkVersion 21
140-
targetSdkVersion 28
140+
targetSdkVersion 29
141141
applicationId appId
142142
testInstrumentationRunner 'org.catrobat.catroid.runner.UiTestApplicationRunner'
143143
versionCode 79

catroid/proguard-project.txt

-5
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,6 @@
1919
# public *;
2020
#}
2121

22-
23-
# The official support library.
24-
-keep class android.support.v4.app.** { *; }
25-
-keep interface android.support.v4.app.** { *; }
26-
2722
# Library JARs
2823
-keep class com.thoughtworks.xstream.** { *; }
2924
-keep interface com.thoughtworks.xstream.** { *; }

catroid/src/main/java/org/catrobat/catroid/CatroidApplication.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ public class CatroidApplication extends Application implements HasActivityInject
6565
DispatchingAndroidInjector<Activity> dispatchingActivityInjector;
6666
protected AppComponent appComponents;
6767

68-
@TargetApi(28)
68+
@TargetApi(29)
6969
@Override
7070
public void onCreate() {
7171
super.onCreate();

catroid/src/test/java/org/catrobat/catroid/test/robolectric/bricks/BrickAddCategoryTest.java

+3
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525

2626
import android.app.Activity;
2727
import android.content.SharedPreferences;
28+
import android.os.Build;
2829
import android.preference.PreferenceManager;
2930
import android.widget.ListAdapter;
3031

@@ -44,6 +45,7 @@
4445
import org.robolectric.Robolectric;
4546
import org.robolectric.RobolectricTestRunner;
4647
import org.robolectric.android.controller.ActivityController;
48+
import org.robolectric.annotation.Config;
4749

4850
import java.util.ArrayList;
4951
import java.util.Arrays;
@@ -65,6 +67,7 @@
6567
import static org.catrobat.catroid.ui.settingsfragments.SettingsFragment.SETTINGS_SHOW_RASPI_BRICKS;
6668

6769
@RunWith(RobolectricTestRunner.class)
70+
@Config(sdk = {Build.VERSION_CODES.P})
6871
public class BrickAddCategoryTest {
6972

7073
private SpriteActivity activity;

catroid/src/test/java/org/catrobat/catroid/test/robolectric/bricks/BrickSingleFormulaFieldTest.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
package org.catrobat.catroid.test.robolectric.bricks;
2525

2626
import android.app.Activity;
27+
import android.os.Build;
2728
import android.view.View;
2829
import android.widget.TextView;
2930

@@ -143,7 +144,7 @@
143144
import static org.junit.Assert.assertThat;
144145

145146
@RunWith(ParameterizedRobolectricTestRunner.class)
146-
@Config(sdk = {25})
147+
@Config(sdk = {Build.VERSION_CODES.P})
147148
public class BrickSingleFormulaFieldTest {
148149

149150
private SpriteActivity activity;

catroid/src/test/java/org/catrobat/catroid/test/robolectric/bricks/BrickSpinnerDefaultValueTest.java

+3
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525

2626
import android.app.Activity;
2727
import android.content.Context;
28+
import android.os.Build;
2829
import android.view.View;
2930
import android.widget.Spinner;
3031

@@ -67,6 +68,7 @@
6768
import org.robolectric.ParameterizedRobolectricTestRunner;
6869
import org.robolectric.Robolectric;
6970
import org.robolectric.android.controller.ActivityController;
71+
import org.robolectric.annotation.Config;
7072

7173
import java.util.Arrays;
7274
import java.util.Collection;
@@ -76,6 +78,7 @@
7678
import static junit.framework.TestCase.assertNotNull;
7779

7880
@RunWith(ParameterizedRobolectricTestRunner.class)
81+
@Config(sdk = {Build.VERSION_CODES.P})
7982
public class BrickSpinnerDefaultValueTest {
8083

8184
private CategoryBricksFactory categoryBricksFactory;

catroid/src/test/java/org/catrobat/catroid/test/robolectric/bricks/BrickSpinnerTest.java

+3
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
package org.catrobat.catroid.test.robolectric.bricks;
2525

2626
import android.app.Activity;
27+
import android.os.Build;
2728
import android.view.View;
2829
import android.widget.Spinner;
2930

@@ -81,6 +82,7 @@
8182
import org.robolectric.ParameterizedRobolectricTestRunner;
8283
import org.robolectric.Robolectric;
8384
import org.robolectric.android.controller.ActivityController;
85+
import org.robolectric.annotation.Config;
8486

8587
import java.io.File;
8688
import java.util.ArrayList;
@@ -99,6 +101,7 @@
99101
import static org.junit.Assert.assertThat;
100102

101103
@RunWith(ParameterizedRobolectricTestRunner.class)
104+
@Config(sdk = {Build.VERSION_CODES.P})
102105
public class BrickSpinnerTest {
103106

104107
private SpriteActivity activity;

catroid/src/test/java/org/catrobat/catroid/test/robolectric/bricks/BrickStringSpinnerDefaultValueTest.java

+3
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525

2626
import android.app.Activity;
2727
import android.content.Context;
28+
import android.os.Build;
2829
import android.view.View;
2930
import android.widget.Spinner;
3031

@@ -60,6 +61,7 @@
6061
import org.robolectric.ParameterizedRobolectricTestRunner;
6162
import org.robolectric.Robolectric;
6263
import org.robolectric.android.controller.ActivityController;
64+
import org.robolectric.annotation.Config;
6365

6466
import java.util.Arrays;
6567
import java.util.Collection;
@@ -69,6 +71,7 @@
6971
import static junit.framework.TestCase.assertNotNull;
7072

7173
@RunWith(ParameterizedRobolectricTestRunner.class)
74+
@Config(sdk = {Build.VERSION_CODES.P})
7275
public class BrickStringSpinnerDefaultValueTest {
7376

7477
private CategoryBricksFactory categoryBricksFactory;

catroid/src/test/java/org/catrobat/catroid/test/robolectric/bricks/BrickStringSpinnerTest.java

+3
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
package org.catrobat.catroid.test.robolectric.bricks;
2525

2626
import android.app.Activity;
27+
import android.os.Build;
2728
import android.view.View;
2829
import android.widget.Spinner;
2930

@@ -63,6 +64,7 @@
6364
import org.robolectric.ParameterizedRobolectricTestRunner;
6465
import org.robolectric.Robolectric;
6566
import org.robolectric.android.controller.ActivityController;
67+
import org.robolectric.annotation.Config;
6668

6769
import java.util.ArrayList;
6870
import java.util.Arrays;
@@ -80,6 +82,7 @@
8082
import static org.junit.Assert.assertThat;
8183

8284
@RunWith(ParameterizedRobolectricTestRunner.class)
85+
@Config(sdk = {Build.VERSION_CODES.P})
8386
public class BrickStringSpinnerTest {
8487

8588
private SpriteActivity activity;

catroid/src/test/java/org/catrobat/catroid/test/robolectric/bricks/BroadcastBrickTest.java

+3
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525

2626
import android.app.Activity;
2727
import android.content.DialogInterface;
28+
import android.os.Build;
2829
import android.view.View;
2930
import android.widget.Spinner;
3031

@@ -46,6 +47,7 @@
4647
import org.robolectric.ParameterizedRobolectricTestRunner;
4748
import org.robolectric.Robolectric;
4849
import org.robolectric.android.controller.ActivityController;
50+
import org.robolectric.annotation.Config;
4951

5052
import java.util.Arrays;
5153
import java.util.Collection;
@@ -56,6 +58,7 @@
5658
import static junit.framework.Assert.assertNotNull;
5759

5860
@RunWith(ParameterizedRobolectricTestRunner.class)
61+
@Config(sdk = {Build.VERSION_CODES.P})
5962
public class BroadcastBrickTest {
6063

6164
private static final String INITAL_MESSAGE = "initialMessage";

catroid/src/test/java/org/catrobat/catroid/test/robolectric/formulaeditor/FormulaEditorEditTextGenericTest.java

+3
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
package org.catrobat.catroid.test.robolectric.formulaeditor;
2525

2626
import android.app.Activity;
27+
import android.os.Build;
2728
import android.os.SystemClock;
2829
import android.view.MotionEvent;
2930
import android.view.View;
@@ -46,6 +47,7 @@
4647
import org.robolectric.ParameterizedRobolectricTestRunner;
4748
import org.robolectric.Robolectric;
4849
import org.robolectric.android.controller.ActivityController;
50+
import org.robolectric.annotation.Config;
4951

5052
import java.util.Arrays;
5153

@@ -54,6 +56,7 @@
5456
import static org.junit.Assert.assertEquals;
5557

5658
@RunWith(ParameterizedRobolectricTestRunner.class)
59+
@Config(sdk = {Build.VERSION_CODES.P})
5760
public class FormulaEditorEditTextGenericTest {
5861

5962
@ParameterizedRobolectricTestRunner.Parameters(name = "{0}" + "-Test")

0 commit comments

Comments
 (0)